Re: Fwd: u32 ht filters

2018-02-12 Thread Jiri Pirko
Mon, Feb 12, 2018 at 04:32:16PM CET, j...@resnulli.us wrote: >Sat, Feb 10, 2018 at 09:41:57PM CET, xiyou.wangc...@gmail.com wrote: > >[...] > @@ -348,7 +340,7 @@ static struct tc_u_common *tc_u_common_find(const struct tcf_proto *tp) h = tc_u_hash(tp);

Re: Fwd: u32 ht filters

2018-02-12 Thread Jiri Pirko
Sat, Feb 10, 2018 at 09:41:57PM CET, xiyou.wangc...@gmail.com wrote: [...] >>>@@ -348,7 +340,7 @@ static struct tc_u_common *tc_u_common_find(const >>>struct tcf_proto *tp) >>> >>>h = tc_u_hash(tp); >>>hlist_for_each_entry(tc, _u_common_hash[h], hnode) { >>>- if

Re: Fwd: u32 ht filters

2018-02-12 Thread Jiri Pirko
Sat, Feb 10, 2018 at 09:41:57PM CET, xiyou.wangc...@gmail.com wrote: >On Wed, Feb 7, 2018 at 11:38 PM, Jiri Pirko wrote: >> Thu, Feb 08, 2018 at 12:08:36AM CET, xiyou.wangc...@gmail.com wrote: >>>On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: Wed, Feb

Re: Fwd: u32 ht filters

2018-02-10 Thread Cong Wang
On Wed, Feb 7, 2018 at 11:38 PM, Jiri Pirko wrote: > Thu, Feb 08, 2018 at 12:08:36AM CET, xiyou.wangc...@gmail.com wrote: >>On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: >>> Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: Hi, Jiri

Re: Fwd: u32 ht filters

2018-02-07 Thread Jiri Pirko
Thu, Feb 08, 2018 at 12:08:36AM CET, xiyou.wangc...@gmail.com wrote: >On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: >> Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: >>>Hi, Jiri >>> >>>Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c >>>breaks the

Re: Fwd: u32 ht filters

2018-02-07 Thread Cong Wang
On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: > Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: >>Hi, Jiri >> >>Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c >>breaks the tc script by Paweł. Please find below for details. > > Did you do the

Re: Fwd: u32 ht filters

2018-02-06 Thread Jiri Pirko
Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: >Hi, Jiri > >Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c >breaks the tc script by Paweł. Please find below for details. Did you do the bisection? The commit just uses block struct instead of q, but since they are in

Fwd: u32 ht filters

2018-02-06 Thread Cong Wang
Hi, Jiri Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c breaks the tc script by Paweł. Please find below for details. commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c Author: Jiri Pirko Date: Fri Oct 13 14:01:02 2017 +0200 net: sched: cls_u32: use block instead