Re: Generic PHY lib vs. locking

2006-12-28 Thread Andy Fleming
On Dec 21, 2006, at 22:07, Benjamin Herrenschmidt wrote: Hi Andy ! I've been looking at porting various drivers (EMAC, sungem, spider_net, ...) to the generic PHY stuff. However, I have one significant problem here. One of the things I've been trying to do lately with EMAC and that I plan to

Re: Generic PHY lib vs. locking

2006-12-28 Thread Benjamin Herrenschmidt
> Great! At last glance, only gianfar, fs_enet, and au1000_eth. There > are one or two others that haven't gone in, yet. My hope is that > your changes will not require any changes to the drivers, but I'll > leave that to your discretion. Unfortunately, it will probably have an impact on

Re: Generic PHY lib vs. locking

2006-12-22 Thread Benjamin Herrenschmidt
On Fri, 2006-12-22 at 10:24 -0500, David Hollis wrote: > On Fri, 2006-12-22 at 15:07 +1100, Benjamin Herrenschmidt wrote: > > Hi Andy ! > > > > I've been looking at porting various drivers (EMAC, sungem, > > spider_net, ...) to the generic PHY stuff. However, I have one > > significant problem her

Re: Generic PHY lib vs. locking

2006-12-22 Thread David Hollis
On Fri, 2006-12-22 at 15:07 +1100, Benjamin Herrenschmidt wrote: > Hi Andy ! > > I've been looking at porting various drivers (EMAC, sungem, > spider_net, ...) to the generic PHY stuff. However, I have one > significant problem here. > > One solution would be to change it to use a mutex instead

Generic PHY lib vs. locking

2006-12-21 Thread Benjamin Herrenschmidt
Hi Andy ! I've been looking at porting various drivers (EMAC, sungem, spider_net, ...) to the generic PHY stuff. However, I have one significant problem here. One of the things I've been trying to do lately with EMAC and that I plan to do with others, is to have the PHY polling entirely operate a