Marin Mitov a écrit :
Hi all,
As in: include/linux/netdevice.h (kernel-2.6.24.2) one finds:
static inline void __netif_tx_lock(struct net_device *dev, int cpu)
{
spin_lock(&dev->_xmit_lock);
dev->xmit_lock_owner = cpu;
}
static inline void netif_tx_lock(struct net_device *dev)
{
__netif_tx_lock(dev, smp_processor_id());
}
Does netif_tx_lock(struct net_device *dev) expands into:
cpu = smp_processor_id();
<preempt & shift to another cpu (bogus)>
spin_lock(&dev->_xmit_lock);
dev->xmit_lock_owner = cpu; /* cpu is not the lock owner */
Or to:
spin_lock(&dev->_xmit_lock);
dev->xmit_lock_owner = smp_processor_id();
which is correct?
Hi Marin
This expands to the first version, but netif_tx_lock() is allways called
with preemption disabled.
(Or checks in smp_processor_id() would just trigger)
Eric
(Cced netdev for network related stuff)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
