On Fri, Jan 05, 2018 at 02:44:07AM +0200, Ivan Khoronzhuk wrote:
> + G.Strashko
> The below change also brokes phy connect for am572x..
>
> int genphy_restart_aneg(struct phy_device *phydev)
> {
> - int ctl = phy_read(phydev, MII_BMCR);
> -
> - if (ctl < 0)
> - return c
+ G.Strashko
The below change also brokes phy connect for am572x..
int genphy_restart_aneg(struct phy_device *phydev)
{
- int ctl = phy_read(phydev, MII_BMCR);
-
- if (ctl < 0)
- return ctl;
-
- ctl |= BMCR_ANENABLE | BMCR_ANRESTART;
-
/* Don't isolate the
Am 04.01.2018 um 12:44 schrieb Russell King - ARM Linux:
> On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
>> Parameter mask of phy_modify() holds the bits to be cleared.
>> In the mentioned commit parameter mask seems to be inverted in
>> few cases, what IMO is wrong (see example)
On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
> Parameter mask of phy_modify() holds the bits to be cleared.
> In the mentioned commit parameter mask seems to be inverted in
> few cases, what IMO is wrong (see example).
> Maybe I miss something, could you please check?
Hi Heiner
On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
> Parameter mask of phy_modify() holds the bits to be cleared.
> In the mentioned commit parameter mask seems to be inverted in
> few cases, what IMO is wrong (see example).
I'd be grateful if you could list those that you think are
Parameter mask of phy_modify() holds the bits to be cleared.
In the mentioned commit parameter mask seems to be inverted in
few cases, what IMO is wrong (see example).
Maybe I miss something, could you please check?
And somehow related:
When adding such helpers, wouldn't it make sense to add
helpe
