Re: NAPI: netif_rx_reschedule() ??

2006-08-31 Thread jamal
On Thu, 2006-31-08 at 14:29 -0700, Stephen Hemminger wrote: On Wed, 30 Aug 2006 16:39:14 -0700 Roland Dreier [EMAIL PROTECTED] wrote: Roland makes sense -- especially since the caller probably also Roland deducted N from *budget, and netif_rx_reschedule() doesn't Roland touch

Re: NAPI: netif_rx_reschedule() ??

2006-08-31 Thread Alexey Kuznetsov
Hello! However I'm confused about a couple of things, and there are only two uses of netif_rx_reschedule() in the kernel, so I'm a little stuck. First, do not believe to even single bit of code or docs about netif_rx_reschedule(). It was used once in the first version of NAPI for 3com driver

NAPI: netif_rx_reschedule() ??

2006-08-30 Thread Roland Dreier
I'm looking at updating IP-over-InfiniBand to use NAPI, and due to the way IB works, the driver is going to be susceptible to the rotting packet problem. It seems I'm going to have to call netif_rx_reschedule(). However I'm confused about a couple of things, and there are only two uses of

Re: NAPI: netif_rx_reschedule() ??

2006-08-30 Thread Stephen Hemminger
On Wed, 30 Aug 2006 15:07:31 -0700 Roland Dreier [EMAIL PROTECTED] wrote: I'm looking at updating IP-over-InfiniBand to use NAPI, and due to the way IB works, the driver is going to be susceptible to the rotting packet problem. It seems I'm going to have to call netif_rx_reschedule().

Re: NAPI: netif_rx_reschedule() ??

2006-08-30 Thread Roland Dreier
Stephen The undo should really be handled by the caller, not in Stephen netif_rx_reschedule. The existing interface assumes you Stephen have already deducted N from your quota and so it needs Stephen to be put back. makes sense -- especially since the caller probably also

Re: NAPI: netif_rx_reschedule() ??

2006-08-30 Thread Stephen Hemminger
On Wed, 30 Aug 2006 16:31:12 -0700 Roland Dreier [EMAIL PROTECTED] wrote: Stephen The undo should really be handled by the caller, not in Stephen netif_rx_reschedule. The existing interface assumes you Stephen have already deducted N from your quota and so it needs Stephen to

Re: NAPI: netif_rx_reschedule() ??

2006-08-30 Thread Roland Dreier
Roland makes sense -- especially since the caller probably also Roland deducted N from *budget, and netif_rx_reschedule() doesn't Roland touch that. Actually, why does undoing the change to quota make sense? Presumably I passed N packets to netif_receive_skb() -- why shouldn't I