Non-linear SKBs

2007-10-11 Thread Kristian Evensen
Hello, I have developed a small patch for the TCP code in 2.6.19 and it works flawlessly. A couple of days ago I decided to make it compatible with 2.6.22.5 and have stumbled upon a problem I cannot solve. In 2.6.19 it seems that all packets (at least the ones my patch work with) are linear,

Re: Non-linear SKBs

2007-10-11 Thread David Miller
From: Kristian Evensen <[EMAIL PROTECTED]> Date: Fri, 12 Oct 2007 00:54:37 +0200 > I have developed a small patch for the TCP code in 2.6.19 and it works > flawlessly. A couple of days ago I decided to make it compatible with > 2.6.22.5 and have stumbled upon a problem I cannot solve. > > In 2.

Re: Non-linear SKBs

2007-10-12 Thread kristrev
> If the underlying device can do scatter-gather and checksumming, > the TCP code builds outgoing packets by copying user date into > full system pages, and then attaching those pages into the SKB. > The protocol headers sit under the skb->data linear area, and > the user data mostly sits in the u

Re: Non-linear SKBs

2007-10-13 Thread Kristian Evensen
Reading through my mail again, I see that I was a bit unclear. What I want to achieve is to share a frag between to skbs (where one has no earlier referance to it). Sorry. [EMAIL PROTECTED] wrote: If the underlying device can do scatter-gather and checksumming, the TCP code builds outgoing pac

[PATCH net-next v2 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-02 Thread Loic Poulain
There is no guarantee that rmnet rx_handler is only fed with linear skbs, but current rmnet implementation does not check that, leading to crash in case of non linear skbs processed as linear ones. Fix that by ensuring skb linearization before processing. Signed-off-by: Loic Poulain --- v2

[PATCH net-next v3 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-03 Thread Loic Poulain
There is no guarantee that rmnet rx_handler is only fed with linear skbs, but current rmnet implementation does not check that, leading to crash in case of non linear skbs processed as linear ones. Fix that by ensuring skb linearization before processing. Signed-off-by: Loic Poulain Acked-by

[PATCH net-next v4 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-03 Thread Loic Poulain
There is no guarantee that rmnet rx_handler is only fed with linear skbs, but current rmnet implementation does not check that, leading to crash in case of non linear skbs processed as linear ones. Fix that by ensuring skb linearization before processing. Signed-off-by: Loic Poulain Acked-by

[PATCH net-next v5 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-04 Thread Loic Poulain
There is no guarantee that rmnet rx_handler is only fed with linear skbs, but current rmnet implementation does not check that, leading to crash in case of non linear skbs processed as linear ones. Fix that by ensuring skb linearization before processing. Signed-off-by: Loic Poulain Acked-by

Re: [PATCH net-next v2 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-02 Thread Willem de Bruijn
On Tue, Feb 2, 2021 at 11:08 AM Loic Poulain wrote: > > There is no guarantee that rmnet rx_handler is only fed with linear > skbs, but current rmnet implementation does not check that, leading > to crash in case of non linear skbs processed as linear ones. > > Fix th

Re: [PATCH net-next v2 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-02 Thread subashab
On 2021-02-02 09:16, Loic Poulain wrote: There is no guarantee that rmnet rx_handler is only fed with linear skbs, but current rmnet implementation does not check that, leading to crash in case of non linear skbs processed as linear ones. Fix that by ensuring skb linearization before processing

Re: [PATCH net-next v3 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-03 Thread Willem de Bruijn
On Wed, Feb 3, 2021 at 8:17 AM Loic Poulain wrote: > > There is no guarantee that rmnet rx_handler is only fed with linear > skbs, but current rmnet implementation does not check that, leading > to crash in case of non linear skbs processed as linear ones. > > Fix th

Re: [PATCH net-next v3 2/2] net: qualcomm: rmnet: Fix rx_handler for non-linear skbs

2021-02-03 Thread Loic Poulain
On Wed, 3 Feb 2021 at 15:04, Willem de Bruijn wrote: > > On Wed, Feb 3, 2021 at 8:17 AM Loic Poulain wrote: > > > > There is no guarantee that rmnet rx_handler is only fed with linear > > skbs, but current rmnet implementation does not check that, leading > > to cr