Re: PATCH: Dummy as IMQ replacement

2006-01-04 Thread Andy Furniss
Andy Furniss wrote: I'll get everything upto date and try the new device tomorrow. Just tried the example script with ifb on 2.6.15 and it works OK, will try more complicated tests & iptables soon. Andy. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: PATCH: Dummy as IMQ replacement

2006-01-03 Thread Stephen Hemminger
On Fri, 30 Dec 2005 11:22:41 -0500 jamal <[EMAIL PROTECTED]> wrote: > On Wed, 2005-28-12 at 10:46 -0500, jamal wrote: > > On Wed, 2005-28-12 at 10:39 -0500, jamal wrote: > > [..] > > > I am going to > > > send an iproute2 patch that is only documentation on usage etc. > > > > > > > Attached. >

Re: PATCH: Dummy as IMQ replacement

2005-12-30 Thread Andy Furniss
jamal wrote: On Fri, 2005-30-12 at 09:30 -0500, jamal wrote: Ok, attached is what i tried - the script is not very realistic but demoes that shaping will happen in the real device. Ahh yes - I should have tried with the default class rather than classifying. This behavior is fine and works

Re: PATCH: Dummy as IMQ replacement

2005-12-30 Thread jamal
On Wed, 2005-28-12 at 10:46 -0500, jamal wrote: > On Wed, 2005-28-12 at 10:39 -0500, jamal wrote: > [..] > > I am going to > > send an iproute2 patch that is only documentation on usage etc. > > > > Attached. A new version attached. Actually all it is is a s/dummy/ifb/g cheers, jamal Document

Re: PATCH: Dummy as IMQ replacement

2005-12-30 Thread jamal
On Fri, 2005-30-12 at 09:30 -0500, jamal wrote: > > Ok, when i do this testing i will try to create a script which demos the > functionality. > Ok, attached is what i tried - the script is not very realistic but demoes that shaping will happen in the real device. cheers, jamal What this scrip

Re: PATCH: Dummy as IMQ replacement

2005-12-30 Thread jamal
On Thu, 2005-29-12 at 21:32 +, Andy Furniss wrote: > I mean it would be handy to be able to send a packet to dummy to be > shaped then when that packet "returns" to then classify/shape again on > the real interface. > Shaping should work when the packet comes back to the real device. You h

Re: PATCH: Dummy as IMQ replacement

2005-12-29 Thread Andy Furniss
jamal wrote: On Thu, 2005-29-12 at 17:02 +, Andy Furniss wrote: Could you make it so that you can double queue the traffic - I couldn't do this with dummy/htb (but didn't try that hard). I've read of imq being used like this to enforce linkwide shaping policy above per user shaping. Anot

Re: PATCH: Dummy as IMQ replacement

2005-12-29 Thread jamal
On Thu, 2005-29-12 at 17:02 +, Andy Furniss wrote: > Could you make it so that you can double queue the traffic - I couldn't > do this with dummy/htb (but didn't try that hard). I've read of imq > being used like this to enforce linkwide shaping policy above per user > shaping. Another reas

Re: PATCH: Dummy as IMQ replacement

2005-12-29 Thread Andy Furniss
jamal wrote: I will think of something. But it seems like after talking to other people as well, the consensus is agreeing with you. I will create a new device instead of abusing dummy ;-> Could you make it so that you can double queue the traffic - I couldn't do this with dummy/htb (but

Re: PATCH: Dummy as IMQ replacement

2005-12-29 Thread jamal
On Thu, 2005-29-12 at 17:08 +0100, Patrick McHardy wrote: > jamal wrote: > > On Wed, 2005-28-12 at 18:19 +0100, Patrick McHardy wrote: > > Its one of those 50/50 decisions - I could create a new device, > > what would you think for a name? > > IMQ? :) No, I'm bad coming up with names myself .. >

Re: PATCH: Dummy as IMQ replacement

2005-12-29 Thread Patrick McHardy
jamal wrote: On Wed, 2005-28-12 at 18:19 +0100, Patrick McHardy wrote: You seem to add almost as much ifdefed code to dummy as it currently has, which makes me wonder if a completely new device wouldn't be much cleaner. Its one of those 50/50 decisions - I could create a new device, what woul

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
On Wed, 2005-28-12 at 18:19 +0100, Patrick McHardy wrote: > While I have nothing against the idea, the patch needs a lot > of cleanup. You seem to add almost as much ifdefed code to > dummy as it currently has, which makes me wonder if a completely > new device wouldn't be much cleaner. > Its one

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread Patrick McHardy
While I have nothing against the idea, the patch needs a lot of cleanup. You seem to add almost as much ifdefed code to dummy as it currently has, which makes me wonder if a completely new device wouldn't be much cleaner. jamal wrote: diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index

Re: PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
On Wed, 2005-28-12 at 10:39 -0500, jamal wrote: [..] > I am going to > send an iproute2 patch that is only documentation on usage etc. > Attached. cheers, jamal Documentation on using dummy in place of IMQ Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- diff --git a/doc/actions/action

PATCH: Dummy as IMQ replacement

2005-12-28 Thread jamal
Dave, This is intended for 2.6.16 since it is a new feature. To everyone who has contacted me over the last few months, I apologize for sitting on this for so long (Ive tried to CC a few). I tend to have more time at year end - and so here it is. This patch does not support feature #3 in the thre