Hi all!
It seems to me that there is a leak of struct ip_sf_socklist in the
ip_mc_drop_socket function (in net/ipv4/igmp.c) which is called on socket
close.
This patch corrects it:
diff -Naur linux-2.6.17.8.orig/net/ipv4/igmp.c
linux-2.6.17.8/net/ipv4/igmp.c
--- linux-2.6.17.8.orig/net/ipv4
From: Michal Ruzicka <[EMAIL PROTECTED]>
Date: Thu, 10 Aug 2006 14:07:06 +0200
> This patch corrects it:
Correct or not this patch is corrupted by your email client, turning
tabs into spaces among other things. This makes your patch unusable.
Please configure your email client to not mangle the
From: David Miller <[EMAIL PROTECTED]>
Date: Thu, 10 Aug 2006 05:12:41 -0700 (PDT)
> From: Michal Ruzicka <[EMAIL PROTECTED]>
> Date: Thu, 10 Aug 2006 14:07:06 +0200
>
> > This patch corrects it:
>
> Correct or not this patch is corrupted by your email client, turning
> tabs into spaces among ot
Took some time but this time the inlined patch should be OK.
Hi all!
It seems to me that there is a leak of struct ip_sf_socklist in the
ip_mc_drop_socket function (in net/ipv4/igmp.c) which is called on socket
close.
This patch corrects it:
diff -Naur linux-2.6.17.8.orig/net/ipv4/igmp.c linux
Michal,
This looks correct, but I think a better way to do it is:
in_dev = inetdev_by_index(...)
(void) ip_mc_leave_src()
if (in_dev) {
ip_mc_dec_group()
in_dev_put()
}
That way, sflist internal details aren't visible
> Michal,
> This looks correct, but I think a better way to do it is:
>
> in_dev = inetdev_by_index(...)
> (void) ip_mc_leave_src()
> if (in_dev) {
> ip_mc_dec_group()
> in_dev_put()
> }
>
> That way, sflist internal
From: "Michal Ruzicka" <[EMAIL PROTECTED]>
Date: Fri, 11 Aug 2006 12:04:53 +0100
> You are absolutely right, I just failed to notice that -ENODEV return value
> from ip_mc_del_src()/ip_mc_leave_src() is ignored.
> Here comes the patch:
...
> > Also, ip_mc_leave_group() has the same issue;
Hi,
...
> (Meanwhile, Michal, can I get a Signed-off-by: line from you for these
> patches? Thanks a lot.)
no problem :-)
There is a leak of a socket's multicast source filter list structure
on closing a socket with a multicast source filter set on an interface
that does not exist any more.
T
[EMAIL PROTECTED] wrote on 08/13/2006 08:44:05 PM:
> From: "Michal Ruzicka" <[EMAIL PROTECTED]>
> Date: Fri, 11 Aug 2006 12:04:53 +0100
>
> > You are absolutely right, I just failed to notice that -ENODEV return
value
> > from ip_mc_del_src()/ip_mc_leave_src() is ignored.
> > Here comes the patc
From: David Stevens <[EMAIL PROTECTED]>
Date: Mon, 14 Aug 2006 15:07:08 -0700
> The first patch in that, yes.
>
> Acked-by: David L Stevens <[EMAIL PROTECTED]>
I've applied it and will push to net-2.6.18
> I'm not sure the second one is quite right. The case of concern
> is wher
Hello David,
> Michal,
> I believe the patch I submitted yesterday fixes this
> problem, and in a simpler way.
Somehow I've missed that e-mail (It did not appear on the thread's list at MARC
archives). Sorry for that.
>
> +-DLS
I've reviewed your
"Michal Ruzicka" <[EMAIL PROTECTED]> wrote on 08/17/2006 05:26:35
AM:
> I've reviewed your patch (the IPv4 part of it) and I think I can say
that
> our soulutions are actually quite similar.
> But I can come up with one difference that I'd like know your opinion
on.
If you have a dupli
Here's a patch to fix source filter leakage when a device is removed
and a process leaves the group thereafter. (2nd part of prior discussion)
This patch also includes corresponding fixes for IPv6 multicast source
filters on device removal (1st & 2nd parts of prior discussion, for IPv6).
Hi
> I'm not sure the second one is quite right. The case of concern
> is where an interface is deleted. If you joined (or left) the group by
> address and then deleted the interface, then you wouldn't match the
> index (which wouldn't be set) so the leave wouldn't work, still.
That's righ
The same patch as in previous e-mail with a few typos in comments corrected:
Signed-off-by: Michal Ruzicka <[EMAIL PROTECTED]>
--- linux-2.6.17.8/net/ipv4/igmp.c.orig 2006-08-11 11:50:46.0 +0200
+++ linux-2.6.17.8/net/ipv4/igmp.c 2006-08-16 16:53:08.0 +0200
@@ -1369,13 +1369,
Michal,
I believe the patch I submitted yesterday fixes this
problem, and in a simpler way.
+-DLS
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
Hello,
First of all, thank you for your comments.
> If you have a duplicated address and the application is not using
> interface index to identify the interface, then which one you join or
> leave
> on is not unique, and which one you'll get is not defined. It is, in fact,
> an error to
From: David Stevens <[EMAIL PROTECTED]>
Date: Tue, 15 Aug 2006 17:57:58 -0600
> Here's a patch to fix source filter leakage when a device is removed
> and a process leaves the group thereafter. (2nd part of prior discussion)
>
> This patch also includes corresponding fixes for IPv6 multicast sour
18 matches
Mail list logo
