Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Mark Rutland
Hi, When fuzzing arm64 with Syzkaller, I'm seeing some splats where this_cpu_ptr() is used in the bowels of idr_alloc(), by way of radix_tree_node_alloc(), in a preemptible context: | BUG: using smp_processor_id() in preemptible [] code: syz-executor.1/32582 | caller is debug_smp_process

Re: Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Matthew Wilcox
On Tue, Jan 26, 2021 at 10:47:34AM +, Mark Rutland wrote: > Hi, > > When fuzzing arm64 with Syzkaller, I'm seeing some splats where > this_cpu_ptr() is used in the bowels of idr_alloc(), by way of > radix_tree_node_alloc(), in a preemptible context: I sent a patch to fix this last June. The

Re: Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Mark Rutland
On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > On Tue, Jan 26, 2021 at 10:47:34AM +, Mark Rutland wrote: > > Hi, > > > > When fuzzing arm64 with Syzkaller, I'm seeing some splats where > > this_cpu_ptr() is used in the bowels of idr_alloc(), by way of > > radix_tree_node_all

Re: Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Mark Rutland
On Tue, Jan 26, 2021 at 11:00:05AM -0600, Bjorn Andersson wrote: > On Tue 26 Jan 10:21 CST 2021, Mark Rutland wrote: > > > On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > > > On Tue, Jan 26, 2021 at 10:47:34AM +, Mark Rutland wrote: > > > > Hi, > > > > > > > > When fuzzing a

Re: Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Matthew Wilcox
On Tue, Jan 26, 2021 at 06:36:02PM +, Mark Rutland wrote: > On Tue, Jan 26, 2021 at 11:00:05AM -0600, Bjorn Andersson wrote: > > On Tue 26 Jan 10:21 CST 2021, Mark Rutland wrote: > > > > > On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > > > > On Tue, Jan 26, 2021 at 10:47:34A

Re: Preemptible idr_alloc() in QRTR code

2021-01-27 Thread Bjorn Andersson
On Tue 26 Jan 10:21 CST 2021, Mark Rutland wrote: > On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > > On Tue, Jan 26, 2021 at 10:47:34AM +, Mark Rutland wrote: > > > Hi, > > > > > > When fuzzing arm64 with Syzkaller, I'm seeing some splats where > > > this_cpu_ptr() is used