Re: RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net()

2017-05-22 Thread Sowmini Varadhan
> Do you find information from a Linux allocation failure report sufficient > for such an use case? yes, I suppose that would cover the needed cases. Your change looks good to me. Acked-by: Sowmini Varadhan

Re: RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net()

2017-05-22 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in this function. > > The change itself is harmless, but I'm curious about the "extra" > part: "extra" from what? If this happens, hopefully this will be logged > somewhere? Note that this type of (infrequent) logging noise is useful > in s

Re: [PATCH 3/3] RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net()

2017-05-22 Thread Sowmini Varadhan
On (05/22/17 16:13), SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. The change itself is harmless, but I'm curious about the "extra" part: "extra" from what? If this happens, hopefully this will be logged somewhere? Note that this type of (in

[PATCH 3/3] RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net()

2017-05-22 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 22 May 2017 15:45:31 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Sign