On 2018-11-27 12:11, Xin Long wrote:
> sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu
> changes, but we missed one place in sctp_association_init(). It would
> cause frag_point is zero when sending data.
>
> As says in Jakub's reproducer, if sp->pathmtu is set by
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote:
>
> Jean-Louis Dupond reported poor iscsi TCP receive performance
> that we tracked to backlog drops.
>
> Apparently we fail to send window updates reflecting the
> fact that we are under stress.
>
> Note that we might lack a proper window
A Reno DUPACK means new data in F-RTO step 2.b above are
> * delivered. Lower inflight to clock out (re)tranmissions.
> */
> - if (after(tp->snd_nxt, tp->high_seq) && is_dupack)
> -
On Tue, Nov 27, 2018 at 10:01:40AM -0800, Joe Stringer wrote:
> On Tue, 27 Nov 2018 at 06:49, Nicolas Dichtel
> wrote:
> >
> > Le 26/11/2018 à 23:08, David Ahern a écrit :
> > > On 11/26/18 2:27 PM, Joe Stringer wrote:
> > >> @@ -2405,6 +2407,9 @@ enum bpf_func_id {
> > >> /*
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote:
>
> Tell the compiler that most TCP flows are using SACK these days.
>
> There is no need to add the unlikely() clause in tcp_is_reno(),
> the compiler is able to infer it.
>
> Signed-off-by: Eric Dumazet
> ---
Acked-by: Neal Cardwell
Nice.
>From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf Of
>Sokolowski, Jan
>Sent: Tuesday, November 27, 2018 12:20 AM
>To: intel-wired-...@osuosl.org
>Cc: netdev@vger.kernel.org
>Subject: [Intel-wired-lan] [PATCH] i40e: fix kerneldoc for xsk methods
>
>One method,
On Tue, Nov 27, 2018 at 2:58 PM Willem de Bruijn
wrote:
>
> On Tue, Nov 27, 2018 at 1:41 PM Maxim Mikityanskiy
> wrote:
> >
> > Hi everyone,
> >
> > We are experiencing an issue with Mellanox mlx5 driver, and I tracked it
> > down to
> > the packet_snd function in net/packet/af_packet.c.
> >
>
On Tue, Nov 27, 2018 at 1:41 PM Maxim Mikityanskiy wrote:
>
> Hi everyone,
>
> We are experiencing an issue with Mellanox mlx5 driver, and I tracked it down
> to
> the packet_snd function in net/packet/af_packet.c.
>
> Brief description: when a socket is created by calling `socket(AF_PACKET,
>
On 11/27/18 11:02 AM, Alexei Starovoitov wrote:
> On Mon, Nov 26, 2018 at 09:17:13PM -0800, Yonghong Song wrote:
>> Commit 2667a2626f4d ("bpf: btf: Add BTF_KIND_FUNC
>> and BTF_KIND_FUNC_PROTO") checked the name validity
>> for BTF_KIND_FUNC/BTF_KIND_FUNC_PROTO types such that:
>> .
On Mon, Nov 26, 2018 at 09:17:13PM -0800, Yonghong Song wrote:
> Commit 2667a2626f4d ("bpf: btf: Add BTF_KIND_FUNC
> and BTF_KIND_FUNC_PROTO") checked the name validity
> for BTF_KIND_FUNC/BTF_KIND_FUNC_PROTO types such that:
> . BTF_KIND_FUNC must have a valid identifier name
> . BTF_KIND_PROTO
On 11/27/2018 09:56 AM, Toni Peltonen wrote:
> Previously when unbinding a slave the 802.3ad implementation only told
> partner that the port is not suitable for aggregation by setting the port
> aggregation state from aggregatable to individual. This is not enough. If the
> physical layer still
On Tue, 27 Nov 2018 16:04:29 +, Edward Cree wrote:
> On 10/11/18 05:21, Jakub Kicinski wrote:
> > From: John Hurley
> >
> > Previously, TC block tunnel decap rules were only offloaded when a
> > callback was triggered through registration of the rules egress device.
> > This meant that the
On Tue, 27 Nov 2018 at 06:49, Nicolas Dichtel wrote:
>
> Le 26/11/2018 à 23:08, David Ahern a écrit :
> > On 11/26/18 2:27 PM, Joe Stringer wrote:
> >> @@ -2405,6 +2407,9 @@ enum bpf_func_id {
> >> /* BPF_FUNC_perf_event_output for sk_buff input context. */
> >> #define BPF_F_CTXLEN_MASK
On 11/27/18 7:24 AM, Naresh Kamboju wrote:
> CONFIG_FTRACE_SYSCALLS=y is required for get_cgroup_id_user test case
> this test reads a file from debug trace path
> /sys/kernel/debug/tracing/events/syscalls/sys_enter_nanosleep/id
>
> Signed-off-by: Naresh Kamboju
Acked-by: Yonghong Song
>
From: Daniel Borkmann
Date: Tue, 27 Nov 2018 10:16:17 +0100
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) Fix several bugs in BPF sparc JIT, that is, convergence for fused
>branches, initialization of frame pointer register, and
On Tue, Nov 27, 2018 at 7:57 AM, Eric Dumazet wrote:
> While working on the SACK compression issue Jean-Louis Dupond
> reported, we found that his linux box was suffering very hard
> from tail drops on the socket backlog queue.
>
> First patch hints the compiler about sack flows being the norm.
>
On Mon, Nov 26, 2018 at 02:16:16PM -0800, John Fastabend wrote:
> After being able to add metadata to messages with sk_msg_push_data we
> have also found it useful to be able to "pop" this metadata off before
> sending it to applications in some cases. This series adds a new helper
>
On 10/11/18 05:21, Jakub Kicinski wrote:
> From: John Hurley
>
> Previously, TC block tunnel decap rules were only offloaded when a
> callback was triggered through registration of the rules egress device.
> This meant that the driver had no access to the ingress netdev and so
> could not verify
> -Original Message-
> From: Ioana Ciocoi Radulescu
> Sent: Monday, November 26, 2018 18:27
> To: netdev@vger.kernel.org; da...@davemloft.net
> Cc: Ioana Ciornei ; dsah...@gmail.com; Camelia
> Alexandra Groza
> Subject: [PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP support
>
> We keep
Toni Peltonen wrote:
>Previously when unbinding a slave the 802.3ad implementation only told
>partner that the port is not suitable for aggregation by setting the port
>aggregation state from aggregatable to individual. This is not enough. If the
>physical layer still stays up and we only
Le 26/11/2018 à 23:08, David Ahern a écrit :
> On 11/26/18 2:27 PM, Joe Stringer wrote:
>> @@ -2405,6 +2407,9 @@ enum bpf_func_id {
>> /* BPF_FUNC_perf_event_output for sk_buff input context. */
>> #define BPF_F_CTXLEN_MASK (0xfULL << 32)
>>
>> +/* BPF_FUNC_sk_lookup_tcp and
t; On Mon, Nov 26, 2018 at 07:22:05PM +0800, Xin Long wrote:
> > > > > Now when using stream reconfig to add out streams, stream->out
> > > > > will get re-allocated, and all old streams' information will
> > > > > be copied to the new ones and the
e and recreates another one in the right VRF. This allows for
>> on-the-fly change of the underlay VRF of a VXLAN device.
>>
>> Signed-off-by: Alexis Bauvin
>> Reviewed-by: Amine Kherbouche
>> Tested-by: Amine Kherbouche
>> ---
>
> re-iterating my com
Hi,
On Mon, Nov 26, 2018 at 04:06:27PM -0800, Stephen Hemminger wrote:
> On Tue, 31 Oct 2017 16:28:20 -0700
> Cong Wang wrote:
>
> > On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger
> > wrote:
> > >
> > > IPPROTO_MH comes from include/uapi/linux/in6.h
> > > Maybe it is trying to use old
to disable collecting +
> >distributing to when doing similar port disabling/detaching/removing change.
> >With this patch kernel implementation would behave the same way and ensure
> >partner doesn't consider our actor viable anymore.
>
> After re-reading the releva
On 11/27/2018 04:06 AM, Alexei Starovoitov wrote:
> On Fri, Nov 23, 2018 at 04:44:31PM -0800, Andrey Ignatov wrote:
>> This patch set adds ABI versioning and documentation to libbpf.
>>
>> Patch 1 renames btf_get_from_id to btf__get_from_id to follow naming
>> convention.
>> Patch 2 adds version
On Mon, Nov 26, 2018 at 07:22:05PM +0800, Xin Long wrote:
> > > > > Now when using stream reconfig to add out streams, stream->out
> > > > > will get re-allocated, and all old streams' information will
> > > > > be copied to the new ones and the old
n using stream reconfig to add out streams, stream->out
> > > > will get re-allocated, and all old streams' information will
> > > > be copied to the new ones and the old ones will be freed.
> > > >
> > > > So without stream->out_curr upda
On 11/27/2018 06:55 AM, David Miller wrote:
>
> Move all arguments into output registers from input registers.
>
> This path is exercised by test_verifier.c's "calls: two calls with
> args" test. Adjust BPF_TAILCALL_PROLOGUE_SKIP as needed.
>
> Let's also make the prologue length a constant
Hello!
On 27.11.2018 9:25, Ganesh Goudar wrote:
Total number of VFs supported by PF is used determine the last
^ to
byte of VF's mac address. Number of VFs supported is not always
16, use the variable nvfs to get the number of VFs supported
On 2018/11/26 10:37, Toshiaki Makita wrote:
> On 2018/11/23 1:43, David Ahern wrote:
>> On 11/21/18 5:53 PM, Toshiaki Makita wrote:
We really need consistency in the counters and at a minimum, users
should be able to track packet and byte counters for both Rx and Tx
including XDP.
-the-fly change of the underlay VRF of a VXLAN device.
>
> Signed-off-by: Alexis Bauvin
> Reviewed-by: Amine Kherbouche
> Tested-by: Amine Kherbouche
> ---
re-iterating my comments on the patch this time.
this version still unconditionally calls reopen even if the current
sta
On Mon, 26 Nov 2018 17:56:10 -0800
"Nambiar, Amritha" wrote:
> On 11/26/2018 4:43 PM, David Ahern wrote:
> > On 11/26/18 5:23 PM, Nambiar, Amritha wrote:
> >>> Can tc flower use something similar to ip ru with single port or port
> >>> range handled like this?
> >>>
> >>> },{
> >>>
On Fri, Nov 23, 2018 at 04:44:31PM -0800, Andrey Ignatov wrote:
> This patch set adds ABI versioning and documentation to libbpf.
>
> Patch 1 renames btf_get_from_id to btf__get_from_id to follow naming
> convention.
> Patch 2 adds version script and has more details on ABI versioning.
> Patch 3
On Tue, Nov 27, 2018 at 01:21:00AM +0100, Daniel Borkmann wrote:
> Make the high-level BPF JIT entry a general 'catch-all' and add
> architecture specific entries to make it more clear who actively
> maintains which BPF JIT compiler. The list (L) address implies
> that this eventually lands in the
On Sat, Nov 24, 2018 at 11:20:43PM -0800, Yonghong Song wrote:
> Commit 838e96904ff3 ("bpf: Introduce bpf_func_info")
> added bpf func info support. The userspace is able
> to get better ksym's for bpf programs with jit, and
> is able to print out func prototypes.
>
> For a program containing
On 11/26/2018 4:43 PM, David Ahern wrote:
> On 11/26/18 5:23 PM, Nambiar, Amritha wrote:
>>> Can tc flower use something similar to ip ru with single port or port
>>> range handled like this?
>>>
>>> },{
>>> "priority": 32764,
>>> "src": "172.16.1.0",
>>> "srclen": 24,
On Mon, Nov 26, 2018 at 02:52:18PM -0800, David Miller wrote:
>
> We need to initialize the frame pointer register not just if it is
> seen as a source operand, but also if it is seen as the destination
> operand of a store or an atomic instruction (which effectively is a
> source operand).
>
>
On Mon, Nov 26, 2018 at 01:03:46PM -0800, David Miller wrote:
>
> On T4 and later sparc64 cpus we can use the fused compare and branch
> instruction.
>
> However, it can only be used if the branch destination is in the range
> of a signed 10-bit immediate offset. This amounts to 1024
>
On Mon, Nov 26, 2018 at 02:05:37PM +0100, Daniel Borkmann wrote:
> This set contains a fix for arm64 BPF JIT. First patch generalizes
> ppc64 way of retrieving subprog into bpf_jit_get_func_addr() as core
> code and uses the same on arm64 in second patch. Tested on both arm64
> and ppc64.
>
>
Le 27 nov. 2018 à 01:46, David Ahern a écrit :
> On 11/26/18 5:41 PM, Alexis Bauvin wrote:
>> Le 26 nov. 2018 à 18:54, David Ahern a écrit :
>>> On 11/26/18 9:32 AM, Alexis Bauvin wrote:
Thanks for the review. I’ll send a v5 if you have no other comment on
this version!
>>>
>>> A few
On 11/26/18 5:41 PM, Alexis Bauvin wrote:
> Le 26 nov. 2018 à 18:54, David Ahern a écrit :
>> On 11/26/18 9:32 AM, Alexis Bauvin wrote:
>>> Thanks for the review. I’ll send a v5 if you have no other comment on
>>> this version!
>>
>> A few comments on the test script; see attached which has the
On 11/26/18 5:23 PM, Nambiar, Amritha wrote:
>> Can tc flower use something similar to ip ru with single port or port
>> range handled like this?
>>
>> },{
>> "priority": 32764,
>> "src": "172.16.1.0",
>> "srclen": 24,
>> "ipproto": "tcp",
>> "sport":
Le 26 nov. 2018 à 18:54, David Ahern a écrit :
> On 11/26/18 9:32 AM, Alexis Bauvin wrote:
>> Thanks for the review. I’ll send a v5 if you have no other comment on
>> this version!
>
> A few comments on the test script; see attached which has the changes.
>
> Mainly the cleanup does not need to
On Sat, 24 Nov 2018 17:12:48 -0700
David Ahern wrote:
> IPX was moved to staging at the end of last year. Can decnet follow
> suit? git log seems to indicate no active development in a very long time.
>
> David
I have no problem with dropping decnet support from iproute first.
Presumably
endor implementations like Arista EOS, seem to disable collecting +
>distributing to when doing similar port disabling/detaching/removing change.
>With this patch kernel implementation would behave the same way and ensure
>partner doesn't consider our actor viable anymore.
After
On 11/21/2018 1:42 PM, David Ahern wrote:
> On 11/20/18 11:17 PM, Amritha Nambiar wrote:
>> diff --git a/tc/f_flower.c b/tc/f_flower.c
>> index 65fca04..722647d 100644
>> --- a/tc/f_flower.c
>> +++ b/tc/f_flower.c
>> @@ -494,6 +494,68 @@ static int flower_parse_port(char *str, __u8 ip_proto,
>>
On Tue, 31 Oct 2017 16:28:20 -0700
Cong Wang wrote:
> On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger
> wrote:
> >
> > IPPROTO_MH comes from include/uapi/linux/in6.h
> > Maybe it is trying to use old kernel headers from libc.
>
> So newer iproute2 is not supposed to work with older
>
On 11/26/2018 03:38 AM, Florian Westphal wrote:
> The (out-of-tree) Multipath-TCP implementation needs a significant amount
> of extra space in the skb control buffer.
>
> Increasing skb->cb[] size in mainline is a non-starter for memory and
> and performance reasons (f.e. increase in cb size
On Mon, Nov 26, 2018 at 2:29 PM, Eric Dumazet wrote:
> Kernel support was added in linux-4.18 in commit feb5f2ec6464
> ("tcp: export packets delivery info")
>
> Tested:
>
> ss -ti
> ...
> ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646
> [2607:f8b0:8099:e18::]:38953
> ts sack
On Tue, 2018-11-20 at 14:12 -0800, Saeed Mahameed wrote:
> Hi
>
> This patchset is for mlx5-next shared branch, and will be applied
> there
> once the review is done.
>
> The main idea of this change is to define a flexible scalable and
> simpler low level mlx5 core APIs to upper level
On Wed, 21 Nov 2018 14:06:49 -0700, David Ahern wrote:
> Keeping the basic xdp packets in the standard counters allows Paweł, for
> example, to continue to monitor /proc/net/dev.
>
> Can we get agreement on this? And from there, get updates to the mlx5
> and virtio drivers?
I have a long
On 11/26/18 2:27 PM, Joe Stringer wrote:
> @@ -2405,6 +2407,9 @@ enum bpf_func_id {
> /* BPF_FUNC_perf_event_output for sk_buff input context. */
> #define BPF_F_CTXLEN_MASK(0xfULL << 32)
>
> +/* BPF_FUNC_sk_lookup_tcp and BPF_FUNC_sk_lookup_udp flags. */
> +#define
On 11/26/2018 10:42 PM, David Miller wrote:
>
> 'offset' is constant and if it is zero, no need to subtract it
> from BPF_REG_TMP.
>
> Signed-off-by: David S. Miller
Applied to bpf-next, thanks!
David Miller wrote:
> From: Florian Westphal
> Date: Mon, 26 Nov 2018 22:19:33 +0100
>
> >> In the future please document what is so enormous and absolutely
> >> required that they must put it all into the SKB control block.
> >
> > Ok, will do.
>
> Why don't we establish the details about
From: Florian Westphal
Date: Mon, 26 Nov 2018 22:19:33 +0100
>> In the future please document what is so enormous and absolutely
>> required that they must put it all into the SKB control block.
>
> Ok, will do.
Why don't we establish the details about what MP-TCP needs in the CB
before we
David Miller wrote:
> > This adds an extension infrastructure for sk_buff instead:
> > 1. extension memory is released when the sk_buff is free'd.
> > 2. data is shared after cloning an skb.
> > 3. adding extension to an skb will COW the extension
> >buffer if needed.
>
> So MP-TCP, when
From: Daniel Borkmann
Date: Mon, 26 Nov 2018 14:25:28 +0100
> The following pull-request contains BPF updates for your *net-next* tree.
...
> Please consider pulling these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
>
> Note, there is a tiny merge
From: Florian Westphal
Date: Mon, 26 Nov 2018 12:38:54 +0100
> This adds an extension infrastructure for sk_buff instead:
> 1. extension memory is released when the sk_buff is free'd.
> 2. data is shared after cloning an skb.
> 3. adding extension to an skb will COW the extension
>buffer if
On Mon, Nov 26, 2018 at 08:33:36PM +0100, Pablo Neira Ayuso wrote:
> Hi Marcelo,
Hello!
>
> On Thu, Nov 22, 2018 at 07:08:32PM -0200, Marcelo Ricardo Leitner wrote:
> > On Thu, Nov 22, 2018 at 02:22:20PM -0200, Marcelo Ricardo Leitner wrote:
> > > On Wed, Nov 21, 2018 at 03:51:20AM +0100, Pablo
On Mon, Nov 26, 2018 at 1:19 PM Willem de Bruijn
wrote:
>
> On Mon, Nov 26, 2018 at 1:04 PM Paolo Abeni wrote:
> >
> > On Mon, 2018-11-26 at 12:59 -0500, Willem de Bruijn wrote:
> > > The callers of this function do flush the queue of the other skbs on
> > > error, but only after the call to
t; 1. Same patch, but tighten the retry check inside
>>>>>>>>> bpf_load_program_xattr ?
>>>>>>>>> 2. Move this retry logic into load_program and have different handling
>>>>>>>>> for bpf_create_map_xattr vs bpf
Hi Marcelo,
On Thu, Nov 22, 2018 at 07:08:32PM -0200, Marcelo Ricardo Leitner wrote:
> On Thu, Nov 22, 2018 at 02:22:20PM -0200, Marcelo Ricardo Leitner wrote:
> > On Wed, Nov 21, 2018 at 03:51:20AM +0100, Pablo Neira Ayuso wrote:
> > > Hi,
> > >
> > > This patchset is the third iteration [1]
On 11/26/18 12:06 PM, Alexis Bauvin wrote:
> Moreover, the issue of mixing default and non-default vrf needs to be
> addressed. For now it is stale, as I don’t see any solution (except for
> rewriting the whole thing as you suggested before) to address the
> "Address already in use" made by a
ttr ?
> >>>>>>> 3. Do 2 and move the retry check for maps from bpf_create_map_xattr
> >>>>>>> into bpf_object__create_maps ?
> >>>>>>>
> >>>>>>> (I'm slightly leaning towards #3)
> >>>>&
questions for alexis on that,
I do agree on this. The test shows that a simple down/up is enough, and
the patch was written as a mere convenience.
> - What is the reason for handling NETDEV_CHANGE on the vxlan device
> from the notifier handler. It can be really done in the changelink
> handler
Hello,
My name is ms. Reem Al-Hashimi. The UAE minister of state for international
cooparation. I got your contact from an email database from your country. I
have a financial transaction i would like to discuss with you. Please reply to
reem2...@daum.net, for more details if you are
ce and there are many cases where this is
already done from user-space. A few questions for alexis on that,
- What is the reason for handling NETDEV_CHANGE on the vxlan device
from the notifier handler. It can be really done in the changelink
handler, correct ?
- Also, IIUC, patch5 blindly re-opens
On Mon, Nov 26, 2018 at 1:04 PM Paolo Abeni wrote:
>
> On Mon, 2018-11-26 at 12:59 -0500, Willem de Bruijn wrote:
> > The callers of this function do flush the queue of the other skbs on
> > error, but only after the call to sock_zerocopy_put_abort.
> >
> > sock_zerocopy_put_abort depends on
On Mon, Nov 26, 2018 at 11:32 AM Paolo Abeni wrote:
>
> Hi,
>
> Sorry for the long delay...
>
> On Mon, 2018-11-26 at 10:29 -0500, Willem de Bruijn wrote:
> > @@ -1109,6 +1128,7 @@ static int __ip_append_data(struct sock *sk,
> > error_efault:
> > err = -EFAULT;
> > error:
> > +
On Mon, 2018-11-26 at 12:59 -0500, Willem de Bruijn wrote:
> The callers of this function do flush the queue of the other skbs on
> error, but only after the call to sock_zerocopy_put_abort.
>
> sock_zerocopy_put_abort depends on total rollback to revert the
> sk_zckey increment and suppress the
On 11/26/18 9:32 AM, Alexis Bauvin wrote:
> Thanks for the review. I’ll send a v5 if you have no other comment on
> this version!
A few comments on the test script; see attached which has the changes.
Mainly the cleanup does not need to be called at the end since you setup
the exit trap. The
Bjørn Mork wrote:
> Not that it matters much I guess, but I think LX SFPs were unsupported
> at that time. The LX support appears to have been added under the radar
> while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882
> ("ixgbe: Fix 1G and 10G link stability for X550EM_x
On Sat, Nov 24, 2018 at 11:20:45PM -0800, Yonghong Song wrote:
> The selftest test_btf is changed to test both jit and non-jit.
> The test result should be the same regardless of whether jit
> is enabled or not.
Acked-by: Martin KaFai Lau
On Sat, Nov 24, 2018 at 11:20:44PM -0800, Yonghong Song wrote:
> Commit 838e96904ff3 ("bpf: Introduce bpf_func_info")
> added bpf func info support. The userspace is able
> to get better ksym's for bpf programs with jit, and
> is able to print out func prototypes.
>
> For a program containing
Le 22 nov. 2018 à 18:19, David Ahern a écrit :
> On 11/21/18 6:07 PM, Alexis Bauvin wrote:
>> Creating a VXLAN device with is underlay in the non-default VRF makes
>> egress route lookup fail or incorrect since it will resolve in the
>> default VRF, and ingress fail because the socket listens in
Hi,
Sorry for the long delay...
On Mon, 2018-11-26 at 10:29 -0500, Willem de Bruijn wrote:
> @@ -1109,6 +1128,7 @@ static int __ip_append_data(struct sock *sk,
> error_efault:
> err = -EFAULT;
> error:
> + sock_zerocopy_put_abort(uarg);
> cork->length -= length;
>
On 11/25/18 5:05 PM, Daniel Borkmann wrote:
> On 11/23/2018 02:38 AM, John Fastabend wrote:
>> This adds a BPF SK_MSG program helper so that we can pop data from a
>> msg. We use this to pop metadata from a previous push data call.
>>
>> Signed-off-by: John Fastabend
>> ---
>>
On 11/26/18 3:16 AM, Quentin Monnet wrote:
> 2018-11-26 02:05 UTC+0100 ~ Daniel Borkmann
>> On 11/23/2018 02:38 AM, John Fastabend wrote:
>>> This adds a BPF SK_MSG program helper so that we can pop data from a
>>> msg. We use this to pop metadata from a previous push data call.
>>>
>>>
On Mon, Nov 26, 2018 at 10:46:33PM +0900, Xin Long wrote:
> On Mon, Nov 26, 2018 at 9:54 PM Neil Horman wrote:
> >
> > On Mon, Nov 26, 2018 at 07:22:05PM +0800, Xin Long wrote:
> > > Now when using stream reconfig to add out streams, stream->out
> > > will g
On Mon, Nov 26, 2018 at 9:54 PM Neil Horman wrote:
>
> On Mon, Nov 26, 2018 at 07:22:05PM +0800, Xin Long wrote:
> > Now when using stream reconfig to add out streams, stream->out
> > will get re-allocated, and all old streams' information will
> > be copied to th
On Mon, Nov 26, 2018 at 10:16:50PM +0900, Xin Long wrote:
> On Mon, Nov 26, 2018 at 9:29 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote:
> > > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu
> > > changes, but we missed
On 11/26/2018 01:45 PM, Lorenz Bauer wrote:
> On Sat, 24 Nov 2018 at 22:20, Alexei Starovoitov
> wrote:
>> On Fri, Nov 23, 2018 at 11:25:11PM +0100, Daniel Borkmann wrote:
>>> On 11/22/2018 03:09 PM, Lorenz Bauer wrote:
[...]
LIBBPF_API int bpf_prog_test_run(int prog_fd, int repeat, void
On Fri, Nov 23, 2018 at 07:41:29PM +0100, Heiner Kallweit wrote:
> After switching the r8169 driver to use phylib some user reported that
> their network is broken. This was caused by the genphy PHY driver being
> used instead of the dedicated PHY driver for the RTL8211B. Users
> reported that
On Mon, Nov 26, 2018 at 9:29 PM Marcelo Ricardo Leitner
wrote:
>
> On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote:
> > sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu
> > changes, but we missed one place in sctp_association_init(). It would
> > cause frag_point is
On Mon, Nov 26, 2018 at 07:22:05PM +0800, Xin Long wrote:
> Now when using stream reconfig to add out streams, stream->out
> will get re-allocated, and all old streams' information will
> be copied to the new ones and the old ones will be freed.
>
> So without stream->out_cu
On Mon, Nov 26, 2018 at 9:27 PM Neil Horman wrote:
>
> On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote:
> > I changed to count sk_wmem_alloc by skb truesize instead of 1 to
> > fix the sk_wmem_alloc leak caused by later truesize's change in
> > xfrm in Commit 02968ccf0125 ("sctp: count
t; > > + const void *data;
> > > + __u32 size;
> > > + void *data_out; /* optional */
> > > + __u32 size_out;
> >
> > Small nit: could we name these data_{in,out} and data_size_{in,out} as
> > well, so it's analog to the ones from the bpf_
On Mon, Nov 26, 2018 at 05:02:11PM +0800, Xin Long wrote:
> sctp_assoc_update_frag_point() should be called whenever asoc->pathmtu
> changes, but we missed one place in sctp_association_init(). It would
> cause frag_point is zero when sending data.
>
> As says in Jakub's reproducer, if
On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote:
> I changed to count sk_wmem_alloc by skb truesize instead of 1 to
> fix the sk_wmem_alloc leak caused by later truesize's change in
> xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb
> truesize in sctp_packet_transmit").
>
>
On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote:
> I changed to count sk_wmem_alloc by skb truesize instead of 1 to
> fix the sk_wmem_alloc leak caused by later truesize's change in
> xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb
> truesize in sctp_packet_transmit").
>
>
> -Original Message-
> From: netdev-ow...@vger.kernel.org
> On Behalf Of Ioana Ciocoi Radulescu
> Sent: Friday, November 23, 2018 18:57
> To: netdev@vger.kernel.org; da...@davemloft.net
> Subject: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support
>
> +static int
2018-11-26 02:05 UTC+0100 ~ Daniel Borkmann
> On 11/23/2018 02:38 AM, John Fastabend wrote:
>> This adds a BPF SK_MSG program helper so that we can pop data from a
>> msg. We use this to pop metadata from a previous push data call.
>>
>> Signed-off-by: John Fastabend
>> ---
>>
On Mon, Nov 26, 2018 at 03:05:50PM +0530, Sharath Chandra Vurukala wrote:
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
>
> tcp_retransmit_skb() returns non-zero negative value
Hi Nicolas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/netns-remove-net-arg-from-rtnl_net_fill/20181126-035032
config: x86_64-allmodconfig (attached as .config)
compiler:
> -Original Message-
> From: David Ahern
> Sent: Saturday, November 24, 2018 11:49 PM
> To: Ioana Ciocoi Radulescu ;
> netdev@vger.kernel.org; da...@davemloft.net
> Cc: Ioana Ciornei
> Subject: Re: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support
>
>
On 11/25/2018 07:52 PM, David Miller wrote:
>
> I fixed up the build in your original patch and am about to push that
> out.
Thanks David, sorry for this, I should have compiled the damn thing :/
From: Daniel Borkmann
Date: Mon, 26 Nov 2018 01:16:51 +0100
> The following pull-request contains BPF updates for your *net* tree.
Pulled, thanks.
From: Eric Dumazet
Date: Sun, 25 Nov 2018 15:37:43 -0800
> On Sun, Nov 25, 2018 at 10:29 AM David Miller wrote:
>>
>> From: Eric Dumazet
>> Date: Sun, 25 Nov 2018 08:26:23 -0800
>>
>> > I do not see how one can effectively use skb_insert() without holding
>> > some kind of lock. Otherwise
> Because function naming is the same I'm afraid they easily can be used
> incorrectly (the bugs we just discuss are good examples). Maybe it
> could be an option to reflect the semantics in the name like this
> (better suited proposals welcome):
>
> case 1: mii_xxx_to_linkmode_yyy
> case 2:
901 - 1000 of 145660 matches
Mail list logo
