RE: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-06-09 Thread 高峰
> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Friday, June 9, 2017 3:23 PM > Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks > when fail to register_netdevice > > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote:

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-06-09 Thread Sven Eckelmann
On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because the func batadv_softif_init_late allocate some resources and > it would be invoked in register_netdevice. So we need to invoke the > func batadv_softif_free instead of

RE: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-26 Thread Gao Feng
> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Wednesday, April 26, 2017 3:17 PM > On Mittwoch, 26. April 2017 14:44:24 CEST Gao Feng wrote: > [...] > > I get it now, thanks. > [...] > > BTW, I think although the batadv_softif_create is legacy, we should > > fix it when it still exists

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-26 Thread Sven Eckelmann
On Mittwoch, 26. April 2017 14:44:24 CEST Gao Feng wrote: [...] > I get it now, thanks. [...] > BTW, I think although the batadv_softif_create is legacy, we should fix it > when it still exists :) I didn't meant that we should not fix it. I just said that it looks to me like the fix should look

RE: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-26 Thread Gao Feng
> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Wednesday, April 26, 2017 1:58 PM > On Mittwoch, 26. April 2017 08:41:30 CEST Gao Feng wrote: > > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > > From: Gao Feng > > > > > > Because the func

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-25 Thread Sven Eckelmann
On Mittwoch, 26. April 2017 08:41:30 CEST Gao Feng wrote: > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng > > > > Because the func batadv_softif_init_late allocate some resources and > > it would be invoked in register_netdevice. So

RE: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-25 Thread Gao Feng
> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Tuesday, April 25, 2017 9:53 PM > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng > > > > Because the func batadv_softif_init_late allocate some resources and > > it would be

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

2017-04-25 Thread Sven Eckelmann
On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because the func batadv_softif_init_late allocate some resources and > it would be invoked in register_netdevice. So we need to invoke the > func batadv_softif_free instead of