RE: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-29 Thread Rosen, Rami
Hi, Netanel, +into 5 levels and assignes interrupt delay value to each level. Should be: assigns +The ENA device AQ and AENQ are allocated on probe and freed ontermination. Should be: on termination. + /* commit previously loaded firmare */ Should be: firmware +static int ena_com_hash_key

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
On Tue, Mar 15, 2016 at 01:19:07PM -0500, Dan Williams wrote: > On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > > + > > +The ENA driver supports industry standard TCP/IP offload features > > such > > +as checksum offload and TCP transmit segmentation offload (TSO). > > + > > +Receive-s

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Dan Williams
On Tue, 2016-03-15 at 12:50 +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. > The driver operates variety of ENA adapters through > feature negotiation with the adapter and upgradable commands set. > ENA driver handles PCI Physical and Virtual ENA functions. >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: [...] > diff --git a/drivers/net/ethernet/amazon/Kconfig > b/drivers/net/ethernet/amazon/Kconfig > new file mode 100644 > index 000..bc4f240d > --- /dev/null > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -0,0 +1,27 @@ > +# >

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread Matt Wilson
Hi Netanel, Looks like the last round of internal review went to {lkml,netdev,etc}, so this should be considered a RFC patch. The description still needs work. On Tue, Mar 15, 2016 at 12:50:06PM +0200, Netanel Belgazal wrote: > This is a driver for the Amazon ethernet ENA family. ethernet -> Et

Re: [PATCH] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-03-15 Thread kbuild test robot
Hi Netanel, [auto build test ERROR on net-next/master] [also build test ERROR on v4.5 next-20160315] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Netanel-Belgazal/net-ena-Add-a-driver-for-Am