RE: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-31 Thread Fugang Duan
From: Fabio Estevam <feste...@gmail.com> Sent: Thursday, March 31, 2016 6:57 PM > To: Fugang Duan <fugang.d...@nxp.com> > Cc: Greg Ungerer <g...@uclinux.org>; Troy Kisky > <troy.ki...@boundarydevices.com>; netdev@vger.kernel.org > Subject: Re: [PATCH] net: fec:

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-31 Thread Fabio Estevam
Hi Greg, On Wed, Mar 30, 2016 at 10:17 PM, Greg Ungerer wrote: > Yes, that fixes it. Will you carry this change? Thanks for confirming. Yes, I will submit it later today;

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-31 Thread Fabio Estevam
Hi Andy, On Wed, Mar 30, 2016 at 10:41 PM, Fugang Duan wrote: > > Fabio, we cannot do it like this that may cause confused for the quirk flag > "FEC_QUIRK_HAS_RACC". We can treat FEC_QUIRK_HAS_RACC flag as "this is a non-Coldfire SoC". > > > Hi, Greg, > > The header file

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-30 Thread Greg Ungerer
Hi Andy, On 31/03/16 11:41, Fugang Duan wrote: > From: Fabio Estevam <feste...@gmail.com> Sent: Thursday, March 31, 2016 2:37 > AM >> To: Greg Ungerer <g...@uclinux.org> >> Cc: Troy Kisky <troy.ki...@boundarydevices.com>; netdev@vger.kernel.org >> Su

RE: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-30 Thread Fugang Duan
From: Fabio Estevam <feste...@gmail.com> Sent: Thursday, March 31, 2016 2:37 AM > To: Greg Ungerer <g...@uclinux.org> > Cc: Troy Kisky <troy.ki...@boundarydevices.com>; netdev@vger.kernel.org > Subject: Re: [PATCH] net: fec: stop the "rcv is not +last, " err

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-30 Thread Greg Ungerer
Hi Fabio, On 31/03/16 04:37, Fabio Estevam wrote: > Hi Greg, > > On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer wrote: >> Hi Troy, >> >> Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error >> messages') adds a write to a register that is not present in all >>

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-30 Thread Fabio Estevam
Hi Greg, On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer wrote: > Hi Troy, > > Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error > messages') adds a write to a register that is not present in all > implementations of the FEC hardware module. None of the ColdFire >

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-30 Thread Troy Kisky
On 3/29/2016 8:24 PM, Greg Ungerer wrote: > Hi Troy, > > Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error > messages') adds a write to a register that is not present in all > implementations of the FEC hardware module. None of the ColdFire > SoC parts with the FEC module have the

Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages

2016-03-29 Thread Greg Ungerer
Hi Troy, Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error messages') adds a write to a register that is not present in all implementations of the FEC hardware module. None of the ColdFire SoC parts with the FEC module have the FTRL (0x1b0) register. Does this need a quirk flag to