Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Yegor Yefremov
On Thu, Mar 17, 2016 at 4:28 PM, Andrew Lunn wrote: >> > You should however consider writing a DSA driver for the switch. >> >> Do you mean SWITCHDEV or is this more or less the same? From time to >> time I'm looking at DSA/switchdev patches in the mailing list, but >> there seems to be not so man

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
On Thu, Mar 17, 2016 at 09:14:17AM +0100, Yegor Yefremov wrote: > On Thu, Mar 17, 2016 at 12:05 AM, Andrew Lunn wrote: > > On Wed, Mar 16, 2016 at 11:23:59PM +0100, Yegor Yefremov wrote: > >> Hi Andrew, > >> > >> On Wed, Mar 16, 2016 at 5:18 PM, Andrew Lunn wrote: > >> > On Wed, Mar 16, 2016 at 0

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Yegor Yefremov
On Thu, Mar 17, 2016 at 4:12 PM, Andrew Lunn wrote: >> After changing cpsw_emac0 entry to: >> >> &cpsw_emac0 { >> phy-mode = "rmii"; >> dual_emac_res_vlan = <1>; >> fixed-link { >> speed = <100>; >> full-duplex; >> }; >> }; >> >> I've

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
On Wed, Mar 16, 2016 at 11:23:59PM +0100, Yegor Yefremov wrote: > Hi Andrew, > > On Wed, Mar 16, 2016 at 5:18 PM, Andrew Lunn wrote: > > On Wed, Mar 16, 2016 at 04:59:23PM +0100, Yegor Yefremov wrote: > > > >> This patch breaks my am335x based board, where one of the CPSW slaves > >> is connected

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
> > You should however consider writing a DSA driver for the switch. > > Do you mean SWITCHDEV or is this more or less the same? From time to > time I'm looking at DSA/switchdev patches in the mailing list, but > there seems to be not so many example in kernel. What are the latest > slides, papers

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Yegor Yefremov
On Fri, Aug 14, 2015 at 6:23 AM, wrote: > From: Shaohui Xie > > Currently, if phy state is PHY_RUNNING, we always register a CHANGE > when phy works in polling or interrupt ignored, this will make the > adjust_link being called even the phy link did Not changed. > > checking the phy link to make

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Yegor Yefremov
On Thu, Mar 17, 2016 at 12:05 AM, Andrew Lunn wrote: > On Wed, Mar 16, 2016 at 11:23:59PM +0100, Yegor Yefremov wrote: >> Hi Andrew, >> >> On Wed, Mar 16, 2016 at 5:18 PM, Andrew Lunn wrote: >> > On Wed, Mar 16, 2016 at 04:59:23PM +0100, Yegor Yefremov wrote: >> > >> >> This patch breaks my am335

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Yegor Yefremov
Hi Andrew, On Wed, Mar 16, 2016 at 5:18 PM, Andrew Lunn wrote: > On Wed, Mar 16, 2016 at 04:59:23PM +0100, Yegor Yefremov wrote: > >> This patch breaks my am335x based board, where one of the CPSW slaves >> is connected to IP175D switch chip via RMII interface. Since this >> patch packet receptio

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
> After changing cpsw_emac0 entry to: > > &cpsw_emac0 { > phy-mode = "rmii"; > dual_emac_res_vlan = <1>; > fixed-link { > speed = <100>; > full-duplex; > }; > }; > > I've got packets running in both directions. Great. > Now I have

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
On Wed, Mar 16, 2016 at 04:59:23PM +0100, Yegor Yefremov wrote: > This patch breaks my am335x based board, where one of the CPSW slaves > is connected to IP175D switch chip via RMII interface. Since this > patch packet reception is not working. Hi Yegor Which phy is causing the problem? A PHY i

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-20 Thread Yegor Yefremov
On Thu, Mar 17, 2016 at 2:41 PM, Andrew Lunn wrote: > On Thu, Mar 17, 2016 at 09:14:17AM +0100, Yegor Yefremov wrote: >> On Thu, Mar 17, 2016 at 12:05 AM, Andrew Lunn wrote: >> > On Wed, Mar 16, 2016 at 11:23:59PM +0100, Yegor Yefremov wrote: >> >> Hi Andrew, >> >> >> >> On Wed, Mar 16, 2016 at 5

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-14 Thread Florian Fainelli
Le 08/13/15 21:23, shh@gmail.com a écrit : > From: Shaohui Xie > > Currently, if phy state is PHY_RUNNING, we always register a CHANGE > when phy works in polling or interrupt ignored, this will make the > adjust_link being called even the phy link did Not changed. Right, which is why most d

RE: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-17 Thread Shaohui Xie
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Saturday, August 15, 2015 1:02 AM > To: shh@gmail.com; netdev@vger.kernel.org; da...@davemloft.net > Cc: Xie Shaohui-B21989 > Subject: Re: [PATCH] net: phy: fix PHY_RUNNING in phy_sta

RE: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-17 Thread Shaohui Xie
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Saturday, August 15, 2015 1:02 AM > To: shh@gmail.com; netdev@vger.kernel.org; da...@davemloft.net > Cc: Xie Shaohui-B21989 > Subject: Re: [PATCH] net: phy: fix PHY_RUNNING in phy_sta

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-17 Thread David Miller
From: Date: Fri, 14 Aug 2015 12:23:40 +0800 > From: Shaohui Xie > > Currently, if phy state is PHY_RUNNING, we always register a CHANGE > when phy works in polling or interrupt ignored, this will make the > adjust_link being called even the phy link did Not changed. > > checking the phy link t

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-23 Thread Andy Fleming
On Mon, Aug 17, 2015 at 2:18 PM, David Miller wrote: > > From: > Date: Fri, 14 Aug 2015 12:23:40 +0800 > > > From: Shaohui Xie > > > > Currently, if phy state is PHY_RUNNING, we always register a CHANGE > > when phy works in polling or interrupt ignored, this will make the > > adjust_link being