PJ Waskiewicz wrote:
diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
index 6d7542c..44ecdc6 100644
--- a/net/sched/sch_prio.c
+++ b/net/sched/sch_prio.c
}
+#ifdef CONFIG_NET_SCH_PRIO_MQ
+ /* setup queue to band mapping */
+ if (q->bands < sch->dev->egress_subqueue_co
> PJ Waskiewicz wrote:
> >
> > diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c index
> > 6d7542c..44ecdc6 100644
> > --- a/net/sched/sch_prio.c
> > +++ b/net/sched/sch_prio.c
> > }
> > +#ifdef CONFIG_NET_SCH_PRIO_MQ
> > + /* setup queue to band mapping */
> > + if (q->bands < sch-
Waskiewicz Jr, Peter P wrote:
>>>+band = TC_H_MIN(band) - 1;
>>>+if (band > q->bands) {
>>
>>You copied an off-by-one from an old sch_prio version here.
>
>
> Hmm. This is the sch_prio from the first 2.6.23-dev tree. I'll resync
> and make sure it's the correct one.
Current 2.6.22-rc a
> > Hmm. This is the sch_prio from the first 2.6.23-dev tree. I'll
> > resync and make sure it's the correct one.
>
> Current 2.6.22-rc and net-2.6.23 have
>
> if (band >= q->bands)
I just pulled 2.6.23 down, and see that is true. I must have had that
left over. I'll fix that.
> >
Waskiewicz Jr, Peter P wrote:
Nested netlink attributes, like most qdisc use, instead of
struct tc_rr_qopt (or additionally). The way you've done it
makes it hard to add further attributes later.
I'm going to need to think about this more, since I'm not immediately
getting what you're ref
> BTw, couldn't you just merge sch_rr with prio? AFAICT you
> only need a new dequeue function, a new struct Qdisc_ops and
> a MODULE_ALIAS.
Ok, I have this somewhat working, but need to poll for some help from
the community. I used MODULE_ALIAS("sch_rr") in sch_prio.c, and
modprobe is happily
Waskiewicz Jr, Peter P wrote:
BTw, couldn't you just merge sch_rr with prio? AFAICT you
only need a new dequeue function, a new struct Qdisc_ops and
a MODULE_ALIAS.
Ok, I have this somewhat working, but need to poll for some help from
the community. I used MODULE_ALIAS("sch_rr") in sch_prio.c
> Please post the code.
>
Code is attached. Please forgive the attachment and any whitespace
damage...currently using Doubtlook to send this (cringe).
Thanks,
-PJ Waskiewicz
sch_prio.c
Description: sch_prio.c
Waskiewicz Jr, Peter P wrote:
Please post the code.
Code is attached. Please forgive the attachment and any whitespace
damage...currently using Doubtlook to send this (cringe).
The code looks correct. Are you sure you had the config option
enabled during your test?
-
To unsubscribe
> Waskiewicz Jr, Peter P wrote:
> >> Please post the code.
> >>
> >>
> >
> > Code is attached. Please forgive the attachment and any whitespace
> > damage...currently using Doubtlook to send this (cringe).
> >
>
> The code looks correct. Are you sure you had the config
> option enabled
Waskiewicz Jr, Peter P wrote:
The code looks correct. Are you sure you had the config
option enabled during your test?
Yes. This is the tc command I used to configure the qdisc (with q_rr.c
attached from my patches iproute2 package):
# tc qdisc add dev eth2 root handle 1: rr bands 8
RTNETLI
> > Yes. This is the tc command I used to configure the qdisc (with
> > q_rr.c attached from my patches iproute2 package):
> >
> > # tc qdisc add dev eth2 root handle 1: rr bands 8 RTNETLINK
> answers:
> > No such file or directory
>
> Again, I bet you don't have CONFIG_NET_SCH_RR enabled:
Ch
12 matches
Mail list logo
