Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-15 Thread Alexei Starovoitov
On Mon, Oct 14, 2019 at 10:26:10AM +0200, Magnus Karlsson wrote: > On Sat, Oct 12, 2019 at 6:55 PM Alexei Starovoitov > wrote: > > > > On Fri, Oct 11, 2019 at 1:58 PM John Fastabend > > wrote: > > > > > > Magnus Karlsson wrote: > > > > On Tue, Oct 8, 2019 at 9:29 PM John Fastabend > > > > wrot

Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-14 Thread Magnus Karlsson
On Sat, Oct 12, 2019 at 6:55 PM Alexei Starovoitov wrote: > > On Fri, Oct 11, 2019 at 1:58 PM John Fastabend > wrote: > > > > Magnus Karlsson wrote: > > > On Tue, Oct 8, 2019 at 9:29 PM John Fastabend > > > wrote: > > > > > > > > Magnus Karlsson wrote: > > > > > When the need_wakeup flag was a

Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-12 Thread Alexei Starovoitov
On Fri, Oct 11, 2019 at 1:58 PM John Fastabend wrote: > > Magnus Karlsson wrote: > > On Tue, Oct 8, 2019 at 9:29 PM John Fastabend > > wrote: > > > > > > Magnus Karlsson wrote: > > > > When the need_wakeup flag was added to AF_XDP, the format of the > > > > XDP_MMAP_OFFSETS getsockopt was extend

Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-11 Thread John Fastabend
Magnus Karlsson wrote: > On Tue, Oct 8, 2019 at 9:29 PM John Fastabend > wrote: > > > > Magnus Karlsson wrote: > > > When the need_wakeup flag was added to AF_XDP, the format of the > > > XDP_MMAP_OFFSETS getsockopt was extended. Code was added to the kernel > > > to take care of compatibility is

Re: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-09 Thread Magnus Karlsson
On Tue, Oct 8, 2019 at 9:29 PM John Fastabend wrote: > > Magnus Karlsson wrote: > > When the need_wakeup flag was added to AF_XDP, the format of the > > XDP_MMAP_OFFSETS getsockopt was extended. Code was added to the kernel > > to take care of compatibility issues arrising from running > > applica

RE: [PATCH bpf] libbpf: fix compatibility for kernels without need_wakeup

2019-10-08 Thread John Fastabend
Magnus Karlsson wrote: > When the need_wakeup flag was added to AF_XDP, the format of the > XDP_MMAP_OFFSETS getsockopt was extended. Code was added to the kernel > to take care of compatibility issues arrising from running > applications using any of the two formats. However, libbpf was not > exte