RE: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx FIFO on port 0

2018-03-04 Thread Stefan Chulski
> -Original Message- > From: Thomas Petazzoni [mailto:thomas.petazz...@bootlin.com] > Sent: Sunday, March 04, 2018 11:25 AM > To: Stefan Chulski > Cc: Antoine Tenart ; da...@davemloft.net; > Yan Markman ;

Re: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx FIFO on port 0

2018-03-04 Thread Thomas Petazzoni
Hello, On Sun, 4 Mar 2018 06:29:59 +, Stefan Chulski wrote: > > Is there a reason to hardcode 10KB for port 0, and 3KB for the other ports ? > > Would there be use cases where the user may want different configurations > > ? > > Design requirement are 10KB TX FIFO for the 10Gb/sec and 2.5KB

RE: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx FIFO on port 0

2018-03-03 Thread Stefan Chulski
> On Fri, 2 Mar 2018 16:40:42 +0100, Antoine Tenart wrote: > > > -/* Initialize Tx FIFO's */ > > +/* Initialize Tx FIFO's > > + * The CP110's total tx-fifo size is 19kB. > > + * Use large-size 10kB for fast port but 3kB for others. > > + */ > > Is there a reason to hardcode 10KB for port 0,

Re: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx FIFO on port 0

2018-03-02 Thread Thomas Petazzoni
Hello, On Fri, 2 Mar 2018 16:40:42 +0100, Antoine Tenart wrote: > -/* Initialize Tx FIFO's */ > +/* Initialize Tx FIFO's > + * The CP110's total tx-fifo size is 19kB. > + * Use large-size 10kB for fast port but 3kB for others. > + */ Is there a reason to hardcode 10KB for port 0, and 3KB for