Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST

2017-04-06 Thread Eric Dumazet
On Thu, 2017-04-06 at 10:08 -0400, Neal Cardwell wrote: > On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng wrote: > > If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb. > > When machine is overloaded and mem is exhausted, it may fail to alloc skb. > > Moving the increment of TCP_M

RE: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST

2017-04-06 Thread Gao Feng
Hi Neal > -Original Message- > > On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng wrote: > > If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb. > > When machine is overloaded and mem is exhausted, it may fail to alloc skb. > > Moving the increment of TCP_MIB_OUTRSTS to t

RE: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST

2017-04-06 Thread Gao Feng
CH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS > when fail to transmit RST > > On Thu, Apr 6, 2017 at 9:35 AM, wrote: > > From: Gao Feng > > > > When fail to transmit RST, don't increase TCP_MIB_OUTRSTS in func > > tcp_send_active_reset like the

Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST

2017-04-06 Thread Neal Cardwell
On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng wrote: > If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb. > When machine is overloaded and mem is exhausted, it may fail to alloc skb. Moving the increment of TCP_MIB_OUTRSTS to the top of tcp_send_active_reset() sounds fine to me

Re: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST

2017-04-06 Thread Neal Cardwell
On Thu, Apr 6, 2017 at 9:35 AM, wrote: > From: Gao Feng > > When fail to transmit RST, don't increase TCP_MIB_OUTRSTS in func > tcp_send_active_reset like the case that it only increases > LINUX_MIB_TCPABORTFAILED when fail to alloc skb. > > Signed-off-by: Gao Feng > --- I would be concerned t