Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-06 Thread Neal Cardwell
On Sun, Aug 6, 2017 at 3:44 AM, Willy Tarreau wrote: > > On Sun, Aug 06, 2017 at 07:39:57AM +, maowenan wrote: > > > > [Mao Wenan]It works well with these patches of v3.10, and the > > retransmission packet is about 250ms after TLP probe. > > Thank you very much for these patches under 3.10.

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-06 Thread Neal Cardwell
On Sun, Aug 6, 2017 at 3:44 AM, Willy Tarreau wrote: > > On Sun, Aug 06, 2017 at 07:39:57AM +, maowenan wrote: > > > > [Mao Wenan]It works well with these patches of v3.10, and the > > retransmission packet is about 250ms after TLP probe. > > Thank you very much for these patches under 3.10.

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-06 Thread Willy Tarreau
Yuchung Cheng; Nandita > > Dukkipati; Eric Dumazet > > Subject: Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data > > ACKed/SACKed > > > > On Fri, Aug 04, 2017 at 02:01:34PM -0400, Neal Cardwell wrote: > > > On Fri, Aug 4, 2017 at 1:10 PM, Wil

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-06 Thread maowenan
> -Original Message- > From: Willy Tarreau [mailto:w...@1wt.eu] > Sent: Saturday, August 05, 2017 2:19 AM > To: Neal Cardwell > Cc: maowenan; David Miller; netdev@vger.kernel.org; Yuchung Cheng; Nandita > Dukkipati; Eric Dumazet > Subject: Re: [PATCH net 3/3] tcp: f

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Willy Tarreau
On Fri, Aug 04, 2017 at 02:01:34PM -0400, Neal Cardwell wrote: > On Fri, Aug 4, 2017 at 1:10 PM, Willy Tarreau wrote: > > Hi Neal, > > > > On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: > >> I have attached patches for this fix rebased on to v3.10.107, the > >> latest stable releas

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Neal Cardwell
On Fri, Aug 4, 2017 at 1:10 PM, Willy Tarreau wrote: > Hi Neal, > > On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: >> I have attached patches for this fix rebased on to v3.10.107, the >> latest stable release for 3.10. That's pretty far back in history, so >> there were substantial

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Willy Tarreau
Hi Neal, On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: > I have attached patches for this fix rebased on to v3.10.107, the > latest stable release for 3.10. That's pretty far back in history, so > there were substantial conflict resolutions and adjustments required. > :-) Hope tha

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Neal Cardwell
On Fri, Aug 4, 2017 at 3:33 AM, maowenan wrote: > [Mao Wenan]Follow previous mail, in lower version such as 3.10, I found > there are many timer type, e.g:ICSK_TIME_EARLY_RETRANS, RTO,PTO > are used. I'm not sure there exist some unknown problem if we don't check > isck_pending here and below if b

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Neal Cardwell
On Fri, Aug 4, 2017 at 3:12 AM, maowenan wrote: > > > --- a/net/ipv4/tcp_output.c > > > +++ b/net/ipv4/tcp_output.c > > > @@ -2380,21 +2380,12 @@ bool tcp_schedule_loss_probe(struct sock *sk) > > > u32 rtt = usecs_to_jiffies(tp->srtt_us >> 3); > > > u32 timeout, rto_delta_us; > > > > > > -

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread maowenan
> -Original Message- > From: maowenan > Sent: Tuesday, August 01, 2017 8:20 PM > To: 'Neal Cardwell'; David Miller > Cc: netdev@vger.kernel.org; Yuchung Cheng; Nandita Dukkipati > Subject: RE: [PATCH net 3/3] tcp: fix xmit timer to only be

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread maowenan
> -Original Message- > From: maowenan > Sent: Tuesday, August 01, 2017 8:20 PM > To: 'Neal Cardwell'; David Miller > Cc: netdev@vger.kernel.org; Yuchung Cheng; Nandita Dukkipati > Subject: RE: [PATCH net 3/3] tcp: fix xmit timer to only be

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread Neal Cardwell
On Tue, Aug 1, 2017 at 8:20 AM, maowenan wrote: > > + /* If needed, reset TLP/RTO timer; RACK may later override this. */ > [Mao Wenan] I have question about RACK, if there is no RACK feature > in lower version, who can clear this flag:FLAG_SET_XMIT_TIMER? In the comment, "this" is referring

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread maowenan
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Neal Cardwell > Sent: Tuesday, August 01, 2017 10:58 AM > To: David Miller > Cc: netdev@vger.kernel.org; Neal Cardwell; Yuchung Cheng; Nandita Dukkipati > Subject: [PATCH net 3/3

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-01 Thread Eric Dumazet
On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: > Fix a TCP loss recovery performance bug raised recently on the netdev > list, in two threads: > > (i) July 26, 2017: netdev thread "TCP fast retransmit issues" > (ii) July 26, 2017: netdev thread: > "[PATCH V2 net-next] TLP: Don't res