RE: [PATCH net 5/5] qede: Split PF/VF ndos.

2017-05-17 Thread Mintz, Yuval
> > Looking at my alternatives for solving this, I can't see any 'good' > > options - it seems mightily unorthodox to modify net_device_ops, I.e., > > add/remove an NDO function-pointer based on some device property, and > > having multiple ops declared for the sake of a single feature seems > > un

Re: [PATCH net 5/5] qede: Split PF/VF ndos.

2017-05-17 Thread David Miller
From: "Mintz, Yuval" Date: Wed, 17 May 2017 06:16:46 + > Looking at my alternatives for solving this, I can't see any 'good' > options - it seems mightily unorthodox to modify net_device_ops, > I.e., add/remove an NDO function-pointer based on some device > property, and having multiple ops d

RE: [PATCH net 5/5] qede: Split PF/VF ndos.

2017-05-16 Thread Mintz, Yuval
> PFs and VFs share the same structure of NDOs today, and the VFs explicitly > fails the ndo_xdp() callback stating it doesn't support XDP. > > This results in lots of: > > [qede_xdp:1032(enp131s2)]VFs don't support XDP > [ cut here ] > WARNING: CPU: 4 PID: 1426 at n