RE: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-22 Thread Vadim Pasternak
> -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: Friday, June 22, 2018 1:07 AM > To: Andrew Lunn > Cc: Vadim Pasternak ; da...@davemloft.net; > netdev@vger.kernel.org; j...@resnulli.us > Subject: Re: [PATCH v0 03/12] mlxsw: core:

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Guenter Roeck
On Thu, Jun 21, 2018 at 08:34:40PM +0200, Andrew Lunn wrote: > > Hi Andrew, > > Adding Guenter Roeck, the HWMON maintainer. > > > The temperature of each individual module can be obtained > > through ethtool. > > You mean via --module-info? > > FYI: I plan to add hwmon support to the kernel

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Andrew Lunn
> It means I will have 64 thermal zones for each module (actually for the > some coming new systems will support 128 modules, plus thermal zone > for ASIC ambient temperatures. > And each zone will try to control same PWM. > As I result PWM will be extremely jumpy and non-effective. Hi Vadim

RE: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Vadim Pasternak
9:35 PM > > > To: Vadim Pasternak ; Guenter Roeck > > > > > > Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us > > > Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment > > > module for port temperature reading > > >

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Andrew Lunn
.@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us > > Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for > > port temperature reading > > > > > Hi Andrew, > > > > Adding Guenter Roeck, the HWMON maintainer. > > > > &g

RE: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Vadim Pasternak
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, June 21, 2018 9:35 PM > To: Vadim Pasternak ; Guenter Roeck us.net> > Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us > Subject: Re: [PATCH v0 03/12] mlxsw: core:

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Andrew Lunn
> Hi Andrew, Adding Guenter Roeck, the HWMON maintainer. > The temperature of each individual module can be obtained > through ethtool. You mean via --module-info? FYI: I plan to add hwmon support to the kernel SFP code. So if you ever decide to swap to the kernel SFP code, not your own, the

RE: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Vadim Pasternak
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, June 21, 2018 8:11 PM > To: Vadim Pasternak > Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us > Subject: Re: [PATCH v0 03/12] mlxsw: core: Add core environment

Re: [PATCH v0 03/12] mlxsw: core: Add core environment module for port temperature reading

2018-06-21 Thread Andrew Lunn
> New internal API reads the temperature from all the modules, which are > equipped with the thermal sensor and exposes temperature according to > the worst measure. All individual temperature values are normalized to > pre-defined range. Hi Vadim Could you explain this normalization process.