> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Friday, July 8, 2016 0:02
> On Thu, Jun 30, Dexuan Cui wrote:
>
> > +/* The MTU is 16KB per the host side's design. */
> > +struct hvsock_recv_buf {
> > + unsigned int data_len;
> > + unsigned int data_offset;
> > +
> > + struct vmpipe_prot
On Thu, Jun 30, Dexuan Cui wrote:
> +/* The MTU is 16KB per the host side's design. */
> +struct hvsock_recv_buf {
> + unsigned int data_len;
> + unsigned int data_offset;
> +
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE * 4];
Please use some macro related to the proto
asow...@redhat.com; Vitaly Kuznetsov
> ; Cathy Avery ; KY Srinivasan
>
> Cc: Haiyang Zhang ; Rolf Neugebauer
>
> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
>
> On Tue, 2016-07-05 at 09:31 +, Dexuan Cui wrote:
>
> > > > +/* This
> From: Joe Perches [mailto:j...@perches.com]
>
> > +#define sk_to_hvsock(__sk) ((struct hvsock_sock *)(__sk))
> > +#define hvsock_to_sk(__hvsk) ((struct sock *)(__hvsk))
>
> Might as well be static inlines
Hi Joe,
Thank you for the suggestions (again)! :-)
I'll change them to static inlines.
On Tue, 2016-07-05 at 09:31 +, Dexuan Cui wrote:
> > > +/* This is the address fromat of Hyper-V Sockets.
> > format
> I suppose you meant I should change
> /* This is ...
> to
> /*
> * This is ...
> I'll fix this.
No, I just meant fromat should be format
On Thu, 2016-06-30 at 15:58 +, Dexuan Cui wrote:
> Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> mechanism between the host and the guest. It's somewhat like TCP over
> VMBus, but the transportation layer (VMBus) is much simpler than IP.
trivia:
> diff --git a/include
From: Dexuan Cui
Date: Tue, 5 Jul 2016 06:46:24 +
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Tuesday, July 5, 2016 14:27
>> To: Dexuan Cui
>> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
>>
>> From: Dexuan Cu
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, July 5, 2016 14:27
> To: Dexuan Cui
> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
>
> From: Dexuan Cui
> Date: Tue, 5 Jul 2016 01:58:31 +
>
> > Not sure if y
From: Dexuan Cui
Date: Tue, 5 Jul 2016 01:58:31 +
> Not sure if you had a chance to review this version.
Why me?
Other people have to review this too.
> Now I have a question: may I split the include/linux/socket.h change
> and ask you to pre-allocate the number for AF_HYPERV to allow
> ba
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> ow...@vger.kernel.org] On Behalf Of Dexuan Cui
> Sent: Thursday, June 30, 2016 23:59
> diff --git a/include/linux/socket.h b/include/linux/socket.h
> index b5cc5a6..0b68b58 100644
> --- a/include/linux/socket.h
> +++ b/include/linux
On Thu, Jun 30, Olaf Hering wrote:
> On Thu, Jun 30, Dexuan Cui wrote:
>
> > -#define AF_MAX 43 /* For now.. */
> > +#define AF_MAX 44 /* For now.. */
>
> Should this patch also change the places where AF_MAX is used,
> like all the arrays in net/core/sock.c?
A
> Vitaly Kuznetsov ; Cathy Avery ;
> KY Srinivasan ; Haiyang Zhang
> ; j...@perches.com; Rolf Neugebauer
>
> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
>
> On Thu, Jun 30, Dexuan Cui wrote:
>
> > -#define AF_MAX 43 /*
On Thu, Jun 30, Dexuan Cui wrote:
> -#define AF_MAX 43 /* For now.. */
> +#define AF_MAX 44 /* For now.. */
Should this patch also change the places where AF_MAX is used,
like all the arrays in net/core/sock.c?
Olaf
signature.asc
Description: PGP signature
13 matches
Mail list logo