RE: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-19 Thread Woojung.Huh
>> + if (padlen) { >> + u8 *pad = skb_put(nskb, padlen); >> + >> + memset(pad, 0, padlen); >> + } > >Can you use skb_put_padto() here instead of open coding this? > >> + >> + tag = skb_put(nskb, KSZ_INGRESS_TAG_LEN); >> + tag[0] = 0; >> + tag[1] = 1 <<

Re: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-19 Thread Florian Fainelli
On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding support for the Microchip KSZ switch family tail tagging. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn > --- >