RE: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-18 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > +static int xgmiitorgmii_read_status(struct phy_device *phydev) { > > + struct gmii2rgmii *priv = phydev->priv; > > + u16 val = 0; > > + > > + priv->phy_drv->read_status(phydev); > > This can return an error, in which case phydev->speed sh

Re: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-16 Thread Andrew Lunn
> +static int xgmiitorgmii_read_status(struct phy_device *phydev) > +{ > + struct gmii2rgmii *priv = phydev->priv; > + u16 val = 0; > + > + priv->phy_drv->read_status(phydev); This can return an error, in which case phydev->speed should not be trusted. I've not thought locking all the