Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-08 Thread Jean Tourrilhes
On Tue, Mar 07, 2006 at 07:11:27PM -0800, Simon Barber wrote: Overloading configuration parameters with extra meanings like this makes it harder to configure the system - I think it's useful to keep an on/off function separate from the power setting. Simon The main issue I have

RE: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-07 Thread Simon Barber
Malinen Sent: Monday, March 06, 2006 4:23 PM To: Jean Tourrilhes Cc: netdev@vger.kernel.org; Jiri Benc Subject: Re: [RFC/PATCH 7/13] d80211: remove adm_status On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
Jouni Malinen wrote : On Mon, Mar 06, 2006 at 04:44:27PM +0100, Jiri Benc wrote: PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. It just passes a value to the driver, so it's safe to remove it. This is used to implement radio on/off without having to change

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having to change other parts of the configuration (e.g., set interfaces down). The airo driver use 'txpower' for that. txpower has a 'off' option, and

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
On Mon, Mar 06, 2006 at 03:23:04PM -0800, Jouni Malinen wrote: On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having to change other parts of the configuration (e.g., set interfaces down). The