RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-15 Thread Tuong Tong Lien
..@lists.sourceforge.net > Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible > > > > On 9/1/20 10:52 AM, Tuong Tong Lien wrote: > > > Ok, I've got your concern now. Actually when writing this code, I had the > > same thought as you, but decid

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-30 Thread David Miller
From: Tuong Lien Date: Sun, 30 Aug 2020 02:37:55 +0700 > The 'this_cpu_ptr()' is used to obtain the AEAD key' TFM on the current > CPU for encryption, however the execution can be preemptible since it's > actually user-space context, so the 'using smp_processor_id() in > preemptible' has been obs

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-31 Thread Eric Dumazet
On 8/29/20 12:37 PM, Tuong Lien wrote: > The 'this_cpu_ptr()' is used to obtain the AEAD key' TFM on the current > CPU for encryption, however the execution can be preemptible since it's > actually user-space context, so the 'using smp_processor_id() in > preemptible' has been observed. > > We

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-31 Thread Tuong Tong Lien
er.kernel.org > Cc: tipc-discuss...@lists.sourceforge.net > Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible > > > > On 8/29/20 12:37 PM, Tuong Lien wrote: > > The 'this_cpu_ptr()' is used to obtain the AEAD key' TFM on the current > &g

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-31 Thread Eric Dumazet
mloft.net; >> jma...@redhat.com; ma...@donjonn.com; >> ying@windriver.com; netdev@vger.kernel.org >> Cc: tipc-discuss...@lists.sourceforge.net >> Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible >> >> >> >> On 8/29/20 12:37 PM, Tuong Lie

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-31 Thread Tuong Tong Lien
..@lists.sourceforge.net > Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible > > > > On 8/31/20 1:33 AM, Tuong Tong Lien wrote: > > Hi Eric, > > > > Thanks for your comments, please see my answers inline. > > > >> -Original Message-

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-08-31 Thread Eric Dumazet
nn.com; ying@windriver.com; >> netdev@vger.kernel.org >> Cc: tipc-discuss...@lists.sourceforge.net >> Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible >> >> >> >> On 8/31/20 1:33 AM, Tuong Tong Lien wrote: >>> Hi Eric, >>> >

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-01 Thread Tuong Tong Lien
..@lists.sourceforge.net > Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible > > > > On 8/31/20 3:05 AM, Tuong Tong Lien wrote: > > > > > >> -Original Message- > >> From: Eric Dumazet > >> Sent: Monday, August 31, 20

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-01 Thread Eric Dumazet
nn.com; ying@windriver.com; >> netdev@vger.kernel.org >> Cc: tipc-discuss...@lists.sourceforge.net >> Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible >> >> >> >> On 8/31/20 3:05 AM, Tuong Tong Lien wrote: >>> >>> >>>

RE: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-01 Thread Tuong Tong Lien
..@lists.sourceforge.net > Subject: Re: [net] tipc: fix using smp_processor_id() in preemptible > > > > On 9/1/20 5:18 AM, Tuong Tong Lien wrote: > > > > > >> -Original Message- > >> From: Eric Dumazet > >> Sent: Monday, August 31, 20

Re: [net] tipc: fix using smp_processor_id() in preemptible

2020-09-02 Thread Eric Dumazet
On 9/1/20 10:52 AM, Tuong Tong Lien wrote: > Ok, I've got your concern now. Actually when writing this code, I had the > same thought as you, but decided to relax it because of the following reasons: > 1. I don't want to use any locking methods here that can lead to competition > (thus affect