On Mon, Oct 16, 2006 at 06:07:25PM +0200, Michael Buesch wrote:
On Friday 13 October 2006 21:20, David Kimdon wrote:
All one-bit bitfields have been subsumed into the new 'flags'
structure member and the new IEEE80211_TXCTL_* definitions. The
multiple bit members were converted to u8, s8
I am not particularily attached to bitfields or no bitfields. I am
interested in getting d80211 merged. Bitfields have been discussed
as an important TODO. Perhaps this can serve as a starting point for
discussion of the tasks to complete before d80211 is merged?
On Mon, Oct 16, 2006 at
On Friday 13 October 2006 21:20, David Kimdon wrote:
All one-bit bitfields have been subsumed into the new 'flags'
structure member and the new IEEE80211_TXCTL_* definitions. The
multiple bit members were converted to u8, s8 or u16 as appropriate.
And, eh, did this increase or decrease the
) but the code will remain ugly for ever.
Simon
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Michael Buesch
Sent: Monday, October 16, 2006 9:07 AM
To: David Kimdon
Cc: netdev@vger.kernel.org; John W. Linville; Jiri Benc
Subject: Re: [patch 1/5] d80211: remove
On Monday 16 October 2006 21:34, Simon Barber wrote:
Removing the bitfields makes the code much harder to read and maintain.
Here we are working around a problem with the compiler by making the
code ugly - rather than fixing the compiler. The compilers are getting
better and better (GCC 4 has
