RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-12 Thread Nogah Frankel
> > > > > > Hm. You you need this just because you didn't add the backlog > > > > > > pointer to destroy? AFAIK on destroy we are free to reset > > > > > > stats as well, thus simplifying your driver... Let me know > > > > > > if I misunderstand. > > > > The problem of doing it in destroy is whe

Re: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-12 Thread Jakub Kicinski
ft.net; Ido Schimmel > > ; mlxsw ; j...@mojatatu.com; > > xiyou.wangc...@gmail.com > > Subject: RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support > > stats for PRIO qdisc > > > > > Hm. You you need this just because you didn't add the backlog > &g

RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-12 Thread Nogah Frankel
ubject: RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for > PRIO qdisc > > > > > Hm. You you need this just because you didn't add the backlog > > > > pointer to destroy? AFAIK on destroy we are free to reset stats as > > > > wel

RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-12 Thread Yuval Mintz
> > > Hm. You you need this just because you didn't add the backlog > > > pointer to destroy? AFAIK on destroy we are free to reset stats as > > > well, thus simplifying your driver... Let me know if I > > > misunderstand. > > > > This is meant exactly for the scenario where qdisc didn't get > >

Re: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-12 Thread Jakub Kicinski
On Fri, 12 Jan 2018 00:39:26 + Yuval Mintz wrote: > > Hm. You you need this just because you didn't add the backlog > > pointer to destroy? AFAIK on destroy we are free to reset stats as > > well, thus simplifying your driver... Let me know if I > > misunderstand. > > This is meant exactl

RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-11 Thread Yuval Mintz
> > Support basic stats for PRIO qdisc, which includes tx packets and bytes > > count, drops count and backlog size. The rest of the stats are irrelevant > > for this qdisc offload. > > Since backlog is not only incremental but reflecting momentary value, in > > case of a qdisc that stops being off

Re: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-11 Thread Jakub Kicinski
On Thu, 11 Jan 2018 11:21:02 +0100, Jiri Pirko wrote: > From: Nogah Frankel > > Support basic stats for PRIO qdisc, which includes tx packets and bytes > count, drops count and backlog size. The rest of the stats are irrelevant > for this qdisc offload. > Since backlog is not only incremental but