Re: [PATCH] bonding: enhance the IP address check of arp_ip_target

2006-07-12 Thread Tetsuo Takata
Hi, Thank you for the comments. >> Why not just use sscanf? Here's a fixed version of the previous patch, that uses sscanf. > > Better yet, use a better interface like netlink rather than module > parameters. Wouldn't that be overkill? best regards, --- Signed-off-by: Tetsuo Takata <[EMAIL

Re: [PATCH] bonding: enhance the IP address check of arp_ip_target

2006-07-11 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Why not just use sscanf? Better yet, use a better interface like netlink rather than module parameters. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~

Re: [PATCH] bonding: enhance the IP address check of arp_ip_target

2006-07-11 Thread Stephen Hemminger
On Wed, 12 Jul 2006 13:25:52 +0900 Tetsuo Takata <[EMAIL PROTECTED]> wrote: > Hi, > > > I found this in drivers/net/bonding/bond_main.c. > > /* not complete check, but should be good enough to > > catch mistakes */ > > I made a patch which I believe is little bit better than this, > I hope.