Hi Stephen,
On Thu, 5 Jul 2007, Stephen Hemminger wrote:
> On Wed, 4 Jul 2007 08:56:42 -0500
> Matt Mackall <[EMAIL PROTECTED]> wrote:
> [...]
> > > + if (nt->dev_status) {
> >
> > Why not simply call net_dev_is_up?
>
> The flags field values are really BSD legacy-ish stuff and should not be
> u
On Wed, 4 Jul 2007 08:56:42 -0500
Matt Mackall <[EMAIL PROTECTED]> wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [5/9] netconsole: Introduce dev_status member
> >
> > Introduce a new member in netconsole_target that tr
On Wed, 4 Jul 2007, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> > - goto done;
> > + if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> > + event == NETDEV_CHANG
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> - goto done;
> + if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> + event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> +
On Wed, 4 Jul 2007, Matt Mackall wrote:
> On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> > [...]
> > +/*
> > + * Why no net_dev_is_up() in netdevice.h? The kernel could lose a lot of
> > + * weight if only netdevice.h had the good sense to export such a function.
> > + * Oh well .
On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> From: Satyam Sharma <[EMAIL PROTECTED]>
>
> [5/9] netconsole: Introduce dev_status member
>
> Introduce a new member in netconsole_target that tracks the status (up or
> down) of the underlying interface network device that the spec
