Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-09 Thread Ka-Cheong Poon
On 07/07/2018 01:26 AM, Santosh Shilimkar wrote: Hi Ka-Cheong, On 7/6/2018 8:25 AM, Sowmini Varadhan wrote: On (07/06/18 23:08), Ka-Cheong Poon wrote: As mentioned in a previous mail, it is unclear why the port number is transport specific.  Most Internet services use the same port number

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread Santosh Shilimkar
Hi Ka-Cheong, On 7/6/2018 8:25 AM, Sowmini Varadhan wrote: On (07/06/18 23:08), Ka-Cheong Poon wrote: As mentioned in a previous mail, it is unclear why the port number is transport specific. Most Internet services use the same port number running over TCP/UDP as shown in the IANA database.

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread Sowmini Varadhan
On (07/06/18 23:08), Ka-Cheong Poon wrote: > > As mentioned in a previous mail, it is unclear why the > port number is transport specific. Most Internet services > use the same port number running over TCP/UDP as shown > in the IANA database. And the IANA RDS registration is > the same. What

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread Ka-Cheong Poon
On 07/06/2018 06:15 PM, Sowmini Varadhan wrote: On (07/06/18 17:08), Ka-Cheong Poon wrote: Hmm. Why do you need to include tcp header in ib transport code ? If there is any common function just move to core common file and use it. I think it can be removed as it is left over from earlier

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread santosh.shilim...@oracle.com
On 7/6/18 2:08 AM, Ka-Cheong Poon wrote: On 07/06/2018 01:58 AM, Santosh Shilimkar wrote: diff --git a/net/rds/connection.c b/net/rds/connection.c index abef75d..ca72563 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -142,9 +151,12 @@ static void

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread Sowmini Varadhan
On (07/06/18 17:08), Ka-Cheong Poon wrote: > >Hmm. Why do you need to include tcp header in ib transport > >code ? If there is any common function just move to core > >common file and use it. > > I think it can be removed as it is left over from earlier > changes when the IB IPv6 listener port

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-06 Thread Ka-Cheong Poon
On 07/06/2018 01:58 AM, Santosh Shilimkar wrote: --- a/net/rds/bind.c +++ b/net/rds/bind.c @@ -42,42 +43,58 @@   static const struct rhashtable_params ht_parms = {   .nelem_hint = 768, -    .key_len = sizeof(u64), +    .key_len = RDS_BOUND_KEY_LEN, Do we really need the scope id to be

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-05 Thread Santosh Shilimkar
On 6/27/2018 3:23 AM, Ka-Cheong Poon wrote: This patch changes the internal representation of an IP address to use struct in6_addr. IPv4 address is stored as an IPv4 mapped address. All the functions which take an IP address as argument are also changed to use struct in6_addr. But RDS socket

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-07-03 Thread Ka-Cheong Poon
On 06/30/2018 04:50 PM, David Miller wrote: From: Ka-Cheong Poon Date: Wed, 27 Jun 2018 03:23:27 -0700 This patch changes the internal representation of an IP address to use struct in6_addr. IPv4 address is stored as an IPv4 mapped address. All the functions which take an IP address as

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

2018-06-30 Thread David Miller
From: Ka-Cheong Poon Date: Wed, 27 Jun 2018 03:23:27 -0700 > This patch changes the internal representation of an IP address to use > struct in6_addr. IPv4 address is stored as an IPv4 mapped address. > All the functions which take an IP address as argument are also > changed to use struct