Divy Le Ray wrote:
So, it sounds like Krishna's patch is ok, because the race does not
exist anymore in this driver?
The first part is right indeed, but the second part is breaking the
current usage of txq_stopped and
the logic that stops and restarts the Tx queue.
I can submit a patch fixi
So, it sounds like Krishna's patch is ok, because the race does not
exist anymore in this driver?
The first part is right indeed, but the second part is breaking the
current usage of txq_stopped and
the logic that stops and restarts the Tx queue.
I can submit a patch fixing it. Plese let me
Marin Mitov wrote:
On Tuesday 26 February 2008 12:59:04 am you wrote:
Divy Le Ray wrote:
From: "Divy Le Ray" <[EMAIL PROTECTED]>
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and
Divy Le Ray wrote:
From: "Divy Le Ray" <[EMAIL PROTECTED]>
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and others use. LLTX is a lost cause
for hardware device drivers, and in f
> From: "Divy Le Ray" <[EMAIL PROTECTED]>
> Date: Wed, 20 Feb 2008 21:57:08 -0800
>
> > The driver is cxgb3 here, it uses LLTX.
>
> That's extremely unfortunate, hopefully you can update it to
> use a model like tg3 and others use. LLTX is a lost cause
> for hardware device drivers, and in fact
From: "Divy Le Ray" <[EMAIL PROTECTED]>
Date: Wed, 20 Feb 2008 21:57:08 -0800
> The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and others use. LLTX is a lost cause
for hardware device drivers, and in fact we'd like to rem
Hi Divy,
But the race doesn't exist even for LLTX drivers these days. There is no
way two cpu's can execute the xmit handler at the same time.
Thanks,
- KK
> > > > The first part of the patch removes the !netif_queue_stopped(dev).
> > > > It opens the race discussed a while ago between Stephen
> -Original Message-
> From: David Miller [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, February 20, 2008 9:47 PM
> To: [EMAIL PROTECTED]
> Cc: Divy Le Ray; [EMAIL PROTECTED]; [EMAIL PROTECTED];
> netdev@vger.kernel.org
> Subject: Re: [git patches] net driver updat
From: Krishna Kumar2 <[EMAIL PROTECTED]>
Date: Thu, 21 Feb 2008 09:13:49 +0530
> Hi Divy,
>
> > > Explain why, so I can include it in the changelog please...
> >
> > Hi Jeff,
> >
> > The first part of the patch removes the !netif_queue_stopped(dev).
> > It opens the race discussed a while ago bet
Hi Divy,
> > Explain why, so I can include it in the changelog please...
>
> Hi Jeff,
>
> The first part of the patch removes the !netif_queue_stopped(dev).
> It opens the race discussed a while ago between Stephen hemminger and
> David Miller:
> http://marc.info/?l=linux-netdev&m=113383224512427&
Jeff Garzik wrote:
Divy Le Ray wrote:
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
master.kernel.org:/pu
Divy Le Ray wrote:
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/g
Ben Dooks wrote:
These two where meant to be from Laurent Pinchart, they do have
the correct signed-off lines in for him and start with "Patch from:". Is
there any chance of fixing the authour attribution now?
The first line of the changeset mentions it. Other than that, nope.
Jeff
On Mon, Feb 11, 2008 at 12:05:16PM -0500, Jeff Garzik wrote:
> Mostly fixes, a few cleanups (generally assisting fixes), and an
> exception for PS3 wireless because it had been posted, reviewed and
> acked for a while, just not committed.
Thanks, good to get the DM9000 changes moving.
> Please p
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 11 Feb 2008 12:05:16 -0500
> Mostly fixes, a few cleanups (generally assisting fixes), and an
> exception for PS3 wireless because it had been posted, reviewed and
> acked for a while, just not committed.
>
> Please pull from 'upstream-davem' branch
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 6 Feb 2008 06:49:50 -0500
> Please pull from 'upstream-davem' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-davem
>
> to receive the following updates:
Pulled, thanks Jeff.
--
To unsubscribe from this l
From: David Miller <[EMAIL PROTECTED]>
Date: Fri, 01 Feb 2008 21:52:10 -0800 (PST)
> From: Jeff Garzik <[EMAIL PROTECTED]>
> Date: Fri, 1 Feb 2008 16:03:38 -0500
>
> > Please pull from 'upstream2-davem' branch of
>
> This is now pulled and pushed back out to net-2.6
The first S2io patch breaks
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 1 Feb 2008 16:03:38 -0500
> Please pull from 'upstream2-davem' branch of
This is now pulled and pushed back out to net-2.6
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
M
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 1 Feb 2008 16:03:38 -0500
> This submit is based on top of Linus's tree, since I'm not sure what's
> going on with net-2.6.git and my previous (lost?) submission.
>
> These changes do /not/ include anything from the previous submission,
> which was
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 22 Jan 2008 06:02:31 -0500
> NOTE: This is the igb as Auke submitted it. It still needs a review
> against ultra-recent Intel driver work.
>
> Please pull from 'upstream-davem' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netde
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 18 Jan 2008 15:17:21 -0500
>
> Please pull from the 'upstream' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream
>
> to receive my 2.6.25 net driver queue into davem/net-2.6.25.git:
Pulled and pushed back o
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 21:03:26 -0400
>
> Please pull from the 'upstream-davem' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-davem
>
> to receive these changes:
Pulled and pushed back out, thanks Jeff!
-
To unsub
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 5 Oct 2007 14:20:08 -0400
> Please pull from 'upstream-davem' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-davem
>
Pulled, and pushed back out to net-2.6.24, thanks Jeff.
-
To unsubscribe from this lis
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Wed, 3 Oct 2007 14:39:16 -0400
>
> Normally I wait a day or two between pushes, to queue up patches and
> also to avoid annoying my upstream :) But this includes a couple fixes
> I felt should be upstreamed sooner rather than later.
>
> Please pull fr
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 2 Oct 2007 13:41:50 -0400
> Please pull from the 'upstream' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream
Pulled and pushed back out to net-2.6.24, thanks Jeff!
-
To unsubscribe from this list: send the lin
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Thu, 20 Sep 2007 03:26:10 -0400
> Please pull from the 'upstream' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream
>
> to receive the following changes:
Pulled into net-2.6.24 and pushed out, thanks Jeff!
-
To uns
On Mon, Jul 16, 2007 at 06:57:21PM -0400, Jeff Garzik wrote:
> Minor fixes and cleanups, and a wireless pull from Linville.
>
> Please pull from 'upstream-linus' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-linus
>
did you get the dgrs removal patch?
On Wed, 11 Jul 2007, Jiri Kosina wrote:
On Tue, 10 Jul 2007, Jeff Garzik wrote:
Various minor updates. The only thing of note is sk98lin driver
removal. Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
This is pro
On Tue, 10 Jul 2007, Jeff Garzik wrote:
> Various minor updates. The only thing of note is sk98lin driver removal.
> Please pull from 'upstream-linus' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-linus
This is probably going to cause a new entry in r
On Friday 18 May 2007, Andrew Morton wrote:
>On Fri, 18 May 2007 23:46:21 +0200
>
>Mariusz Koz__owski <[EMAIL PROTECTED]> wrote:
>> Hello,
>>
>> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
>> > index 7053026..111f23d 100644
>> > --- a/drivers/net/smc91x.h
>> > +++ b/drivers/net/smc91
> > > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> > > index 7053026..111f23d 100644
> > > --- a/drivers/net/smc91x.h
> > > +++ b/drivers/net/smc91x.h
> > > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
> >
> > ...
> >
> > > +#define SMC_outb(v, a, r) __ __
On Fri, 18 May 2007 23:46:21 +0200
Mariusz Koz__owski <[EMAIL PROTECTED]> wrote:
> Hello,
>
> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> > index 7053026..111f23d 100644
> > --- a/drivers/net/smc91x.h
> > +++ b/drivers/net/smc91x.h
> > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void
Hello,
> diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> index 7053026..111f23d 100644
> --- a/drivers/net/smc91x.h
> +++ b/drivers/net/smc91x.h
> @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
...
> +#define SMC_outb(v, a, r) outw(((inw((a)+((r)&~1))*(0xf
On Sun, Apr 29, 2007 at 12:19:01PM -0400, Jeff Garzik wrote:
>
> (just sent this upstream to Linus and Andrew)
>
> The only really notable thing is the merging of the wireless driver for
> the OLPC, libertas.
I don't think it's quite ready yet, at least I've got no feedback about
completion of t
On Wed, 2007-02-21 at 08:27 -0500, John W. Linville wrote:
> On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote:
> >
> > >
> > >Dan Williams (1):
> > > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
> >
> > Where did this spring from ?
> > I see no posting of this pat
On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote:
>
> >
> >Dan Williams (1):
> > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
>
> Where did this spring from ?
> I see no posting of this patch let alone
> an ACK.
> The patch is also doing rather more than the descr
On Wed, 2007-02-21 at 12:46 +0100, Roger While wrote:
> >
> >Dan Williams (1):
> > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
>
> Where did this spring from ?
wireless
> I see no posting of this patch let alone
> an ACK.
> The patch is also doing rather more than the des
> I don't have any good ideas, please try to figure out what's wrong. Is
> there a debug switch for the network layer that forces the network layer
> to verify the CHECKSUM_UNNECESSARY blocks?
>
Good news. The latest -git driver seems to fix the problem.
So maybe something got broken with the
Andreas Kleen wrote:
No idea, but unlikely. The fix removes a duplicate request_irq call.
Is
it possible that the both instances run concurrently?
The system has two Forcedeth ports, but only one has a cable connected.
I don't think there is any parallelism. Just one connection with a lot
> No idea, but unlikely. The fix removes a duplicate request_irq call.
> Is
> it possible that the both instances run concurrently?
The system has two Forcedeth ports, but only one has a cable connected.
I don't think there is any parallelism. Just one connection with a lot
of data. It didn't hap
Andi Kleen wrote:
My NF4Pro machine now reliably does
Disconnecting: Bad packet length 3742984839.
when I display a lot of data through ssh. Apparently it generates some
corruption that's not caught by the TCP checksum.
The nic does hw checksumming - thus the tcp checksum won't catch drive
On Saturday 20 May 2006 19:55, Andrew Morton wrote:
> Linus Torvalds <[EMAIL PROTECTED]> wrote:
> >
> >
> >
> > On Sat, 20 May 2006, Andrew Morton wrote:
> > > Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > > >
> > > > Andrew Morton:
> > > >revert "forcedeth: fix multi irq issues"
> > >
> >
Linus Torvalds <[EMAIL PROTECTED]> wrote:
>
>
>
> On Sat, 20 May 2006, Andrew Morton wrote:
> > Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > >
> > > Andrew Morton:
> > >revert "forcedeth: fix multi irq issues"
> >
> > Manfred just found the fix for this, so we should no longer need to reve
On Sat, 20 May 2006, Andrew Morton wrote:
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
> >
> > Andrew Morton:
> >revert "forcedeth: fix multi irq issues"
>
> Manfred just found the fix for this, so we should no longer need to revert.
Hmm. I already pulled. I guess we can revert the revert a
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> Andrew Morton:
>revert "forcedeth: fix multi irq issues"
Manfred just found the fix for this, so we should no longer need to revert.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
46 matches
Mail list logo
