Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-04-12 Thread John W. Linville
On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: > this is something that ieee80211 does that's completely wrong. > Drivers need to report the _exact_ ESSID from the air in their scan > results. It's up to the user space app to deal with ESSID length of 0. What is the outcome of thi

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length,not ""

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 14:14 -0800, Jouni Malinen wrote: > wpa_supplicant does indeed require that the scan results are reported > correctly. I don't see much point in the results if they are not > correct.. It is unfortunate if you need to use this kind of patch since > it would not work very well

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length,not ""

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 09:31:56PM +, David Woodhouse wrote: > wpa_supplicant appears to be aware of none of this -- it expects the > SSID to be precisely correct in the scan results after it does an active > probe for a specific SSID. Thus, it doesn't work when SSID broadcasting > is turned o

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 11:05 -0600, James Ketrenos wrote: > Dan Williams wrote: > > this is something that ieee80211 does that's completely wrong. > > Because it is not a part of the 802.11 specification, AP vendors have > each implemented their own method for disguising the SSID. Some set the >

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jean Tourrilhes
On Fri, Mar 24, 2006 at 12:28:45PM -0800, Jouni Malinen wrote: > > > But, before going into deep technical discussions, we may want > > to remind us what is the goal of this API. The goal is to present the > > user a list of potential networks that can be used by him, in the case > > he doesn'

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 11:41:14AM -0800, Jean Tourrilhes wrote: > I've seen time where people said SSID when referring to the > BSSID, so I just wanted the terminology to be without ambiguity. Well.. It is just somewhat funny to see ESSID being used in Linux wireless discussion when most o

Re: Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jean Tourrilhes
Jouni Malinen wrote : > > On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: > > > this is something that ieee80211 does that's completely wrong. > > Drivers need to report the _exact_ ESSID from the air in their scan > > results. It's up to the user space app to deal with ESSID leng

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread James Ketrenos
James Ketrenos wrote: > In light of the above, I started playing with a raw packet interface on > the ipw2200 and ipw3945 projects that export all frames to user space in > radiotap format through a 2nd network device. I am working on changing > the way the raw packet interface is configured to b

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 11:05:02AM -0600, James Ketrenos wrote: > Since the scan results are supposed to report networks found; the first > agreement we need to make between user space and the kernel is how we > define a 'network', and how do we determine when a network has been > updated? Whenev

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread Dan Williams
On Fri, 2006-03-24 at 11:05 -0600, James Ketrenos wrote: > Dan Williams wrote: > > this is something that ieee80211 does that's completely wrong. > > See (untested) attached to change ieee80211 to expose the SSID as received. Patch looks good to me in principle. All I'm objecting to is the whe

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread James Ketrenos
Dan Williams wrote: > this is something that ieee80211 does that's completely wrong. Because it is not a part of the 802.11 specification, AP vendors have each implemented their own method for disguising the SSID. Some set the length to the actual SSID length but put fill the SSID with '\0', som

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not ""

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 10:57 -0500, Dan Williams wrote: > this is something that ieee80211 does that's completely > wrong. Drivers need to report the _exact_ ESSID from the air in their > scan results. It's up to the user space app to deal with ESSID length > of 0. That makes a lot of sense. On

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not""

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: > this is something that ieee80211 does that's completely wrong. > Drivers need to report the _exact_ ESSID from the air in their scan > results. It's up to the user space app to deal with ESSID length of 0. I agree that "" should no