Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Michael Pyne
On Monday 04 February 2008, Ayaz Abdulla wrote: > Jeff Garzik wrote: > > Ayaz Abdulla wrote: > >> I believe Michael determined that a newer BIOS fixes this issue. > > > > That's a solution that makes vendors happy... but we still have to deal > > with it in Linux. There are plenty of the old broke

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread H. Peter Anvin
Jeff Garzik wrote: Indeed, that would work too... though we would need to put out a call for Gigabyte testers during 2.6.25-rc. It is an entirely reasonable scenario for NVIDIA to deploy a fix to Gigabyte, which would then return us to the same scenario we have today: some work and some d

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Ayaz Abdulla
Jeff Garzik wrote: Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the s

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Ayaz Abdulla
Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and fli

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Andrew Morton
On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > NAK - this fixes one set of users, and breaks a working set of users. > > Need to add DMI check for the specific motherboard (dmi_check_system), > and flip flag acc

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
H. Peter Anvin wrote: Jeff Garzik wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check.

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread H. Peter Anvin
Jeff Garzik wrote: Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check. Either that, or detec

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Michael Pyne <[EMAIL PROTECTED]> Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of th