Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace: [810956e9]

Re: fib_hash removal

2007-03-15 Thread Patrick McHardy
Jarek Poplawski wrote: On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace:

Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On Thu, Mar 15, 2007 at 08:43:59AM +0100, Patrick McHardy wrote: ... On 14-03-2007 23:49, Patrick McHardy wrote: ... BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 ... Yes, Robert already sent me a patch to remove the bogus

Re: fib_hash removal

2007-03-15 Thread Jarek Poplawski
On Thu, Mar 15, 2007 at 10:15:44AM +0100, Jarek Poplawski wrote: ... BTW: it seems fib_tree wasn't used too much, so probably, before killing fib_hash, fib_tree should be made Kconfig default for some time. Sorry! Let fib_tree stay out of Kconfig and make fib_trie the default. Jarek P. - To

Re: fib_hash removal

2007-03-14 Thread Patrick McHardy
David Miller wrote: Another thing I'd like to accomplish is to kill off fib_hash leaving just fib_trie. I can't do that until any and all functionality regressions which may or may not exist in fib_trie vs. fib_hash are discussed and resolved. So can we start composing a list of stuff to