Re: net: Fix skb csum races when peeking

2015-07-15 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Mon, 13 Jul 2015 20:01:42 +0800 When we calculate the checksum on the recv path, we store the result in the skb as an optimisation in case we need the checksum again down the line. This is in fact bogus for the MSG_PEEK case as this is done

Re: net: Fix skb csum races when peeking

2015-07-14 Thread Eric Dumazet
On Mon, 2015-07-13 at 20:01 +0800, Herbert Xu wrote: ---8--- When we calculate the checksum on the recv path, we store the result in the skb as an optimisation in case we need the checksum again down the line. This is in fact bogus for the MSG_PEEK case as this is done without any

Re: net: Fix skb csum races when peeking

2015-07-13 Thread Herbert Xu
On Mon, Jul 13, 2015 at 08:01:42PM +0800, Herbert Xu wrote: PS we seem to no longer use the hardware checksum in case of CHECKSUM_COMPLETE, I wonder why that is? Nevermind, it's still there. I was just looking in the wrong place. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: