Re: stmmac driver...

2016-12-12 Thread Giuseppe CAVALLARO
Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and p

Re: stmmac driver...

2016-12-13 Thread Jie Deng
Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: > Hi David > > On 12/7/2016 7:06 PM, David Miller wrote: >> >> Giuseppe and Alexandre, >> >> There are a lot of patches and discussions happening around the stammc >> driver lately and both of you are listed as the maintainers. >> >> I reall

Re: stmmac driver...

2016-12-14 Thread Jie Deng
Hi David, Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and participatio

Re: stmmac driver...

2016-12-14 Thread Giuseppe CAVALLARO
Hello Jie On 12/14/2016 5:05 AM, Jie Deng wrote: Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are list

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
Hi David, On 12/07/2016 07:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, an

Re: stmmac driver...

2016-12-08 Thread David Miller
From: Alexandre Torgue Date: Thu, 8 Dec 2016 14:55:04 +0100 > Maybe I forget some series. Do you have others in mind ? Please see the thread titled: "net: ethernet: Initial driver for Synopsys DWC XLGMAC" which seems to be discussing consolidation of various drivers for the same IP core, of wh

Re: stmmac driver...

2016-12-08 Thread Alexandre Torgue
On 12/08/2016 04:25 PM, David Miller wrote: From: Alexandre Torgue Date: Thu, 8 Dec 2016 14:55:04 +0100 Maybe I forget some series. Do you have others in mind ? Please see the thread titled: "net: ethernet: Initial driver for Synopsys DWC XLGMAC" which seems to be discussing consolidatio

Re: stmmac driver...

2016-12-09 Thread Jie Deng
On 2016/12/8 23:25, David Miller wrote: > From: Alexandre Torgue > Date: Thu, 8 Dec 2016 14:55:04 +0100 > >> Maybe I forget some series. Do you have others in mind ? > Please see the thread titled: > > "net: ethernet: Initial driver for Synopsys DWC XLGMAC" > > which seems to be discussing conso

Re: stmmac driver...

2016-12-09 Thread Niklas Cassel
Hello Jie Deng In your cover letter you wrote dwc-eth-xxx.x The DWC ethernet core layer (DWC ECL). This layer contains codes can be shared by different DWC series ethernet cores Does this mean that code in dwc-eth-xxx.x is common to all the different Synopsys IPs, GMAC, XGMAC and XLGMAC ? R

Re: Re: stmmac driver...

2016-12-12 Thread Niklas Cassel
(resend with netdev included) On 12/09/2016 05:29 PM, Jie Deng wrote: > > On 2016/12/9 18:50, Niklas Cassel wrote: >> Hello Jie Deng >> >> >> In your cover letter you wrote >> >> dwc-eth-xxx.x >> The DWC ethernet core layer (DWC ECL). This layer contains codes >> can be shared by different DWC s

Re: stmmac driver timeout issue

2021-03-04 Thread Andrew Lunn
On Thu, Mar 04, 2021 at 01:14:31PM +, Joakim Zhang wrote: > > Hello Andrew, Hello Jakub, > > You may can give some suggestions based on your great networking knowledge, > thanks in advance! > > I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility > timeout when acce

Re: stmmac driver timeout issue

2021-03-04 Thread Florian Fainelli
On 3/4/21 5:14 AM, Joakim Zhang wrote: > > Hello Andrew, Hello Jakub, > > You may can give some suggestions based on your great networking knowledge, > thanks in advance! > > I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility > timeout when accessing VLAN Filter regis

RE: stmmac driver timeout issue

2021-03-08 Thread Joakim Zhang
n > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/4/21 5:14 AM, Joakim Zhang wrote: > > > > Hello Andrew, Hello Jakub, > > > > You may can give some suggestions based on your great networking > knowledge, thanks

Re: stmmac driver timeout issue

2021-03-08 Thread Florian Fainelli
On 3/8/21 4:45 AM, Joakim Zhang wrote: > > Hi Florian, Andrew, > > Thanks for your help, after debug, It seems related to PHY(RTL8211FDI). It > stop output RXC clock for dozens to hundreds milliseconds during > auto-negotiation, and there is no such issue with AR8031. > When do ifup/ifdown test

RE: stmmac driver timeout issue

2021-03-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年3月9日 1:57 > To: Joakim Zhang ; Jakub Kicinski > ; Andrew Lunn > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/8/21 4:45 AM, Joakim Zhang wrote: > > > >

Re: stmmac driver timeout issue

2021-03-12 Thread Florian Fainelli
On 3/11/21 4:04 AM, Joakim Zhang wrote: > >> -Original Message- >> From: Florian Fainelli >> Sent: 2021年3月9日 1:57 >> To: Joakim Zhang ; Jakub Kicinski >> ; Andrew Lunn >> Cc: netdev@vger.kernel.org >> Subject: Re: stmmac driver timeout issu

Re: stmmac driver timeout issue

2021-03-12 Thread Russell King - ARM Linux admin
On Fri, Mar 12, 2021 at 10:33:06AM -0800, Florian Fainelli wrote: > On 3/11/21 4:04 AM, Joakim Zhang wrote: > > I have a question about PHY framework, please point me if something I > > misunderstanding. > > There are many scenarios from PHY framework would trigger auto-nego, such > > as switch f

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: > Hi, > > Thanks for responding. > > Tried below suggested way. Still observing the issue - It seems stmmac has a bug in the RX side when using TSO which is causing all the RX descriptors to be consumed. The stmmac_rx() function wil

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: > ++net-dev > > Hi Bhadram, > > On 09-05-2018 12:03, Bhadram Varka wrote: >> Hi, >> >> Thanks for responding. >> >> Tried below suggested way. Still observing the issue - > It seems stmmac has a bug in the RX side when using TSO which is > causing

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Bhadram Varka
Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Tried below suggested way. Still observing the issue - It seems stmmac has a bug in the RX side w

Re: STMMAC driver with TSO enabled issue

2018-05-10 Thread Jose Abreu
On 10-05-2018 16:08, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 7:59 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 10-05-2018 09:55, Jose Abreu wrote: >>> ++net-dev >>> >>> Hi Bhadram, >>> >>> On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Trie

Re: STMMAC driver with TSO enabled issue

2018-05-14 Thread Bhadram Varka
Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: ++net-dev Hi Bhadram, On 09-05-2018 12:03, Bhadram Varka wrote: Hi, Thanks for responding. Tr

Re: STMMAC driver with TSO enabled issue

2018-05-28 Thread Jose Abreu
Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: > Hi Jose, > > On 5/25/2018 8:02 PM, Jose Abreu wrote: >> On 25-05-2018 15:25, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: > Hi Jose,

Re: STMMAC driver with TSO enabled issue

2018-05-29 Thread Bhadram Varka
Hi Jose, On 5/28/2018 4:26 PM, Jose Abreu wrote: Hi Bhadram, On 28-05-2018 10:15, Bhadram Varka wrote: Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Vark

Re: STMMAC driver with TSO enabled issue

2018-05-17 Thread Jose Abreu
Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 9:15 PM, Jose Abreu wrote: >> >> >> On 10-05-2018 16:08, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: > ++net

Re: STMMAC driver with TSO enabled issue

2018-05-23 Thread Bhadram Varka
Hi Jose, On 5/17/2018 7:43 PM, Jose Abreu wrote: Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: Hi Jose, On 5/10/2018 9:15 PM, Jose Abreu wrote: On 10-05-2018 16:08, Bhadram Varka wrote: Hi Jose, On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Jose Abreu
Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > > After some time if check Tx descriptor status - then I see only > below > > [..] > [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 > > index 025 and 026 descriptors processed but not index 027. > > At this stage Tx DMA is

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Bhadram Varka
Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 index 025 and 026 descriptors processed but not

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: > Hi Jose, > > On 5/24/2018 3:01 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 24-05-2018 06:58, Bhadram Varka wrote: >>> >>> After some time if check Tx descriptor status - then I see only >>> below >>> >>> [..] >>> [85788.286730] 027 [0x82795

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Bhadram Varka
Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.

Re: STMMAC driver with TSO enabled issue

2018-05-25 Thread Jose Abreu
On 25-05-2018 15:25, Bhadram Varka wrote: > Hi Jose, > > On 5/25/2018 7:35 PM, Jose Abreu wrote: >> Hi Bhadram, >> >> On 25-05-2018 05:41, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: > >>>

Re: STMMAC driver with TSO enabled issue

2018-05-28 Thread Bhadram Varka
Hi Jose, On 5/25/2018 8:02 PM, Jose Abreu wrote: On 25-05-2018 15:25, Bhadram Varka wrote: Hi Jose, On 5/25/2018 7:35 PM, Jose Abreu wrote: Hi Bhadram, On 25-05-2018 05:41, Bhadram Varka wrote: Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Vark