Re: TCP one-by-one acking - RFC interpretation question

2018-04-12 Thread Yuchung Cheng
On Wed, Apr 11, 2018 at 5:06 AM, Michal Kubecek wrote: > On Wed, Apr 11, 2018 at 12:58:37PM +0200, Michal Kubecek wrote: >> There is something else I don't understand, though. In the case of >> acking previously sacked and never retransmitted segment, >> tcp_clean_rtx_queue() calculates the parame

Re: TCP one-by-one acking - RFC interpretation question

2018-04-11 Thread Michal Kubecek
On Wed, Apr 11, 2018 at 12:58:37PM +0200, Michal Kubecek wrote: > There is something else I don't understand, though. In the case of > acking previously sacked and never retransmitted segment, > tcp_clean_rtx_queue() calculates the parameters for tcp_ack_update_rtt() > using > > if (sack->

Re: TCP one-by-one acking - RFC interpretation question

2018-04-11 Thread Michal Kubecek
On Fri, Apr 06, 2018 at 09:49:58AM -0700, Eric Dumazet wrote: > Cc Neal and Yuchung if they missed this thread. > > On 04/06/2018 08:03 AM, Michal Kubecek wrote: > > On Fri, Apr 06, 2018 at 05:01:29AM -0700, Eric Dumazet wrote: > >> > >> > >> On 04/06/2018 03:05 AM, Michal Kubecek wrote: > >>> Hel

Re: TCP one-by-one acking - RFC interpretation question

2018-04-06 Thread Eric Dumazet
Cc Neal and Yuchung if they missed this thread. On 04/06/2018 08:03 AM, Michal Kubecek wrote: > On Fri, Apr 06, 2018 at 05:01:29AM -0700, Eric Dumazet wrote: >> >> >> On 04/06/2018 03:05 AM, Michal Kubecek wrote: >>> Hello >>> >>> I encountered a strange behaviour of some (non-linux) TCP stack whi

Re: TCP one-by-one acking - RFC interpretation question

2018-04-06 Thread Michal Kubecek
On Fri, Apr 06, 2018 at 05:01:29AM -0700, Eric Dumazet wrote: > > > On 04/06/2018 03:05 AM, Michal Kubecek wrote: > > Hello, > > > > I encountered a strange behaviour of some (non-linux) TCP stack which > > I believe is incorrect but support engineers from the company producing > > it claim is O

Re: TCP one-by-one acking - RFC interpretation question

2018-04-06 Thread Eric Dumazet
On 04/06/2018 03:05 AM, Michal Kubecek wrote: > Hello, > > I encountered a strange behaviour of some (non-linux) TCP stack which > I believe is incorrect but support engineers from the company producing > it claim is OK. > > Assume a client (sender, Linux 4.4 kernel) sends a stream of MSS sized

TCP one-by-one acking - RFC interpretation question

2018-04-06 Thread Michal Kubecek
Hello, I encountered a strange behaviour of some (non-linux) TCP stack which I believe is incorrect but support engineers from the company producing it claim is OK. Assume a client (sender, Linux 4.4 kernel) sends a stream of MSS sized segments but segments 2, 4 and 6 do not reach the server (rec