[PATCH bpf v4 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since commit 6f8a57ccf851 ("bpf: Make verifier log more relevant by default"), the verifier discards log messages for successfully-verified programs. This broke test_offload.py which is looking for a verification message from the driver callba

[PATCH bpf v3 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since 6f8a57ccf85 ("bpf: Make verifier log more relevant by default"), the verifier discards log messages for successfully-verified programs. This broke test_offload.py which is looking for a verification message from the driver callback. Change test_off

[PATCH bpf v2 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails

2020-12-04 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since 6f8a57ccf85 ("bpf: Make verifier log more relevant by default"), the verifier discards log messages for successfully-verified programs. This broke test_offload.py which is looking for a verification message from the driver callback. Change test_off

[PATCH bpf 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails

2020-12-03 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since 6f8a57ccf85 ("bpf: Make verifier log more relevant by default"), the verifier discards log messages for successfully-verified programs. This broke test_offload.py which is looking for a verification message from the driver callback. Change test_off

[PATCH bpf 1/2] bpf: fix BTF verification of enums

2019-09-17 Thread Alexei Starovoitov
vmlinux BTF has enums that are 8 byte and 1 byte in size. 2 byte enum is a valid construct as well. Fix BTF enum verification to accept those sizes. Fixes: 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)") Signed-off-by: Alexei Starovoitov Acked-by: Martin KaFai Lau ---

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-16 Thread Jiong Wang
gt;> >> >> >> > Andrii Nakryiko writes: >> >> > >> >> >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang >> >> >> wrote: >> >> >>> >> >> >>> Verification layer also needs to handle a

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-15 Thread Andrii Nakryiko
gt;> > > >> >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang > >> >> wrote: > >> >>> > >> >>> Verification layer also needs to handle auxiliar info as well as > >> >>> adjusting > >> >>> subprog start. >

Re: [PATCH v3 bpf 0/3] fix BTF verification size resolution

2019-07-15 Thread Daniel Borkmann
On 7/12/19 7:25 PM, Andrii Nakryiko wrote: > BTF size resolution logic isn't always resolving type size correctly, leading > to erroneous map creation failures due to value size mismatch. > > This patch set: > 1. fixes the issue (patch #1); > 2. adds tests for trickier cases (patch #2); > 3. and c

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-15 Thread Jiong Wang
Andrii Nakryiko writes: > On Thu, Jul 11, 2019 at 5:20 AM Jiong Wang wrote: >> >> >> Jiong Wang writes: >> >> > Andrii Nakryiko writes: >> > >> >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang >> >> wrote: >>

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 5:20 AM Jiong Wang wrote: > > > Jiong Wang writes: > > > Andrii Nakryiko writes: > > > >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: > >>> > >>> Verification layer also needs to handle auxiliar info as well as

Re: [PATCH v3 bpf 0/3] fix BTF verification size resolution

2019-07-12 Thread Yonghong Song
On 7/12/19 10:25 AM, Andrii Nakryiko wrote: > BTF size resolution logic isn't always resolving type size correctly, leading > to erroneous map creation failures due to value size mismatch. > > This patch set: > 1. fixes the issue (patch #1); > 2. adds tests for trickier cases (patch #2); > 3. an

[PATCH v3 bpf 0/3] fix BTF verification size resolution

2019-07-12 Thread Andrii Nakryiko
BTF size resolution logic isn't always resolving type size correctly, leading to erroneous map creation failures due to value size mismatch. This patch set: 1. fixes the issue (patch #1); 2. adds tests for trickier cases (patch #2); 3. and converts few test cases utilizing BTF-defined maps, that p

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 05:42 PM, Andrii Nakryiko wrote: > On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: >> On 07/12/2019 08:03 AM, Yonghong Song wrote: >>> On 7/10/19 11:53 PM, Andrii Nakryiko wrote: BTF size resolution logic isn't always resolving type size correctly, leading to e

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: > > On 07/12/2019 08:03 AM, Yonghong Song wrote: > > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > >> BTF size resolution logic isn't always resolving type size correctly, > >> leading > >> to erroneous map creation failures due to value size

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 08:03 AM, Yonghong Song wrote: > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: >> BTF size resolution logic isn't always resolving type size correctly, leading >> to erroneous map creation failures due to value size mismatch. >> >> This patch set: >> 1. fixes the issue (patch #1); >> 2.

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-11 Thread Yonghong Song
On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > BTF size resolution logic isn't always resolving type size correctly, leading > to erroneous map creation failures due to value size mismatch. > > This patch set: > 1. fixes the issue (patch #1); > 2. adds tests for trickier cases (patch #2); > 3. an

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-11 Thread Jiong Wang
Jiong Wang writes: > Andrii Nakryiko writes: > >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >>> >>> Verification layer also needs to handle auxiliar info as well as adjusting >>> subprog start. >>> >>> At this layer, insns inside

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-11 Thread Jiong Wang
Andrii Nakryiko writes: > On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: >> >> Verification layer also needs to handle auxiliar info as well as adjusting >> subprog start. >> >> At this layer, insns inside patch buffer could be jump, but they should &g

[PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-10 Thread Andrii Nakryiko
BTF size resolution logic isn't always resolving type size correctly, leading to erroneous map creation failures due to value size mismatch. This patch set: 1. fixes the issue (patch #1); 2. adds tests for trickier cases (patch #2); 3. and converts few test cases utilizing BTF-defined maps, that p

Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-10 Thread Andrii Nakryiko
On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: > > Verification layer also needs to handle auxiliar info as well as adjusting > subprog start. > > At this layer, insns inside patch buffer could be jump, but they should > have been resolved, meaning they shouldn't jump

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Lucas Bates
On Mon, Jul 8, 2019 at 1:25 PM Alexander Aring wrote: > > Unless I'm off-base here? > > yes you need to know some python, complex code can be hidden by some > helper functionality I guess. > > I have no problem to let this patch in, it will not harm anything... I think I'm going to pull it for the

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Alexander Aring
Hi, On Mon, Jul 08, 2019 at 12:48:12PM -0400, Lucas Bates wrote: > On Thu, Jul 4, 2019 at 4:21 PM Alexander Aring wrote: > > > why you just use eval() as pattern matching operation and let the user > > define how to declare a matching mechanism instead you introduce another > > static matching s

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Lucas Bates
On Thu, Jul 4, 2019 at 4:21 PM Alexander Aring wrote: > why you just use eval() as pattern matching operation and let the user > define how to declare a matching mechanism instead you introduce another > static matching scheme based on a json description? > > Whereas in eval() you could directly

Re: [PATCH v2 net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-07 Thread David Miller
From: Lucas Bates Date: Wed, 3 Jul 2019 20:44:59 -0400 > This patchset introduces JSON as a verification method in tdc and adds a new > plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. > This version includes the patch signoffs missing in the previous s

[RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-04 Thread Jiong Wang
Verification layer also needs to handle auxiliar info as well as adjusting subprog start. At this layer, insns inside patch buffer could be jump, but they should have been resolved, meaning they shouldn't jump to insn outside of the patch buffer. Lineration function for this layer won&#x

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-04 Thread Alexander Aring
Hi, On Wed, Jul 03, 2019 at 08:45:00PM -0400, Lucas Bates wrote: > This patch allows tdc to process JSON output to perform secondary > verification of the command under test. If the verifyCmd generates > JSON, one can provide the 'matchJSON' key to process it > instead of a

[PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-03 Thread Lucas Bates
This patch allows tdc to process JSON output to perform secondary verification of the command under test. If the verifyCmd generates JSON, one can provide the 'matchJSON' key to process it instead of a regex. matchJSON has two elements: 'path' and 'value'. The '

[PATCH v2 net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-03 Thread Lucas Bates
This patchset introduces JSON as a verification method in tdc and adds a new plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. This version includes the patch signoffs missing in the previous submission. The first patch adds the JSON verification to the core tdc script

Re: [PATCH net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-03 Thread David Miller
This entire patch series lacks proper signoffs.

[PATCH net-next 0/3] tc-testing: Add JSON verification and simple traffic generation

2019-07-02 Thread Lucas Bates
This patchset introduces JSON as a verification method in tdc and adds a new plugin, scapyPlugin, as a way to send traffic to test tc filters and actions. The first patch adds the JSON verification to the core tdc script. The second patch makes a change to the TdcPlugin module that will allow

[PATCH net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-02 Thread Lucas Bates
This patch allows tdc to process JSON output to perform secondary verification of the command under test. If the verifyCmd generates JSON, one can provide the 'matchJSON' key to process it instead of a regex. matchJSON has two elements: 'path' and 'value'. The '

Re: [RFC PATCH net-next 1/1] tc-testing: Scapy plugin and JSON verification for tdc

2019-06-24 Thread Alexander Aring
order? > Secondly, we add JSON processing as a method of performing the > verification stage. Each test case can now have a "matchPattern" > or "matchJSON" field which governs the method tdc will use to > process the results. The intent is to make it easier to handle >

[RFC PATCH net-next 1/1] tc-testing: Scapy plugin and JSON verification for tdc

2019-06-09 Thread Lucas Bates
uct the packets. Limitations: For now, only one type of packet can be crafted per test case. Also, knowledge of scapy's syntax is required. Secondly, we add JSON processing as a method of performing the verification stage. Each test case can now have a "matchPattern" or "matchJSON"

Re: [PATCH bpf-next 0/2] bpf: parallel verification

2019-04-22 Thread Alexei Starovoitov
to add memcg accounting and teach oom_badness about the memory used during verification. Then we can drop the mutex for unpriv as well.

Re: [PATCH bpf-next 0/2] bpf: parallel verification

2019-04-22 Thread Daniel Borkmann
On 04/19/2019 04:44 PM, Alexei Starovoitov wrote: > Allow the bpf verifier to run in parallel for root. > > Alexei Starovoitov (2): > bpf: remove global variables > bpf: drop bpf_verifier_lock > > include/linux/bpf_verifier.h | 5 + > kernel/bpf/verifier.c| 33 ++

Re: [PATCH bpf-next 0/2] bpf: parallel verification

2019-04-19 Thread Andrii Nakryiko
On Fri, Apr 19, 2019 at 11:24 AM Alexei Starovoitov wrote: > > Allow the bpf verifier to run in parallel for root. > > Alexei Starovoitov (2): > bpf: remove global variables > bpf: drop bpf_verifier_lock > > include/linux/bpf_verifier.h | 5 + > kernel/bpf/verifier.c| 33

[PATCH bpf-next 0/2] bpf: parallel verification

2019-04-19 Thread Alexei Starovoitov
Allow the bpf verifier to run in parallel for root. Alexei Starovoitov (2): bpf: remove global variables bpf: drop bpf_verifier_lock include/linux/bpf_verifier.h | 5 + kernel/bpf/verifier.c| 33 ++--- 2 files changed, 23 insertions(+), 15 deletions(-

[PATCH v2 bpf-next 03/10] bpf: improve verification speed by not remarking live_read

2019-04-01 Thread Alexei Starovoitov
With large verifier speed improvement brought by the previous patch mark_reg_read() becomes the hottest function during verification. On a typical program it consumes 40% of cpu. mark_reg_read() walks parentage chain of registers to mark parents as LIVE_READ. Once the register is marked there is

[PATCH v2 bpf-next 02/10] bpf: improve verification speed by droping states

2019-04-01 Thread Alexei Starovoitov
Branch instructions, branch targets and calls in a bpf program are the places where the verifier remembers states that led to successful verification of the program. These states are used to prune brute force program analysis. For unprivileged programs there is a limit of 64 states per such

Re: [PATCH bpf-next 3/7] bpf: improve verification speed by not remarking live_read

2019-04-01 Thread Edward Cree
On 30/03/2019 00:16, Alexei Starovoitov wrote: > With large verifier speed improvement brought by the previous patch > mark_reg_read() becomes the hottest function during verification. > On a typical program it consumes 40% of cpu. > mark_reg_read() walks parentage chain of regis

Re: [PATCH bpf-next 2/7] bpf: improve verification speed by droping states

2019-03-29 Thread Alexei Starovoitov
On Fri, Mar 29, 2019 at 08:12:39PM -0700, Jakub Kicinski wrote: > On Fri, 29 Mar 2019 17:16:07 -0700, Alexei Starovoitov wrote: > > Branch instructions, branch targets and calls in a bpf program are > > the places where the verifier remembers states that led to successful > >

Re: [PATCH bpf-next 3/7] bpf: improve verification speed by not remarking live_read

2019-03-29 Thread Jakub Kicinski
On Fri, 29 Mar 2019 17:16:08 -0700, Alexei Starovoitov wrote: > With large verifier speed improvement brought by the previous patch > mark_reg_read() becomes the hottest function during verification. > On a typical program it consumes 40% of cpu. > mark_reg_read() walks parent

Re: [PATCH bpf-next 2/7] bpf: improve verification speed by droping states

2019-03-29 Thread Jakub Kicinski
On Fri, 29 Mar 2019 17:16:07 -0700, Alexei Starovoitov wrote: > Branch instructions, branch targets and calls in a bpf program are > the places where the verifier remembers states that led to successful > verification of the program. > These states are used to prune brute force prog

[PATCH bpf-next 3/7] bpf: improve verification speed by not remarking live_read

2019-03-29 Thread Alexei Starovoitov
With large verifier speed improvement brought by the previous patch mark_reg_read() becomes the hottest function during verification. On a typical program it consumes 40% of cpu. mark_reg_read() walks parentage chain of registers to mark parents as LIVE_READ. Once the register is marked there is

[PATCH bpf-next 2/7] bpf: improve verification speed by droping states

2019-03-29 Thread Alexei Starovoitov
Branch instructions, branch targets and calls in a bpf program are the places where the verifier remembers states that led to successful verification of the program. These states are used to prune brute force program analysis. For unprivileged programs there is a limit of 64 states per such

[PATCH/RFC bpf-next 15/16] selftests: bpf: new field "xlated_insns" for insn scan test after verification

2019-03-26 Thread Jiong Wang
Instruction scan is needed to test the new zero extension insertion pass. This patch introduces the new "xlated_insns" field. Once it is set, instructions from "xlated_insns" will be compared with the instruction sequences returned by prog query syscall after verificati

[PATCH 09/11] netfilter: reject: skip csum verification for protocols that don't support it

2019-02-17 Thread Pablo Neira Ayuso
From: Alin Nastac Some protocols have other means to verify the payload integrity (AH, ESP, SCTP) while others are incompatible with nf_ip(6)_checksum implementation because checksum is either optional or might be partial (UDPLITE, DCCP, GRE). Because nf_ip(6)_checksum was used to validate the pa

[PATCH net-next v2 12/14] octeontx2-af: Add L3 and L4 packet verification mailbox

2018-12-02 Thread Jerin Jacob
From: Vidhya Raman Adds mailbox support for L4 checksum verification and L3 and L4 length verification configuration. Signed-off-by: Vidhya Raman Signed-off-by: Jerin Jacob --- .../net/ethernet/marvell/octeontx2/af/mbox.h | 10 + .../net/ethernet/marvell/octeontx2/af/rvu.h | 3

[PATCH v1 net-next 12/14] octeontx2-af: Add L3 and L4 packet verification mailbox

2018-12-01 Thread Jerin Jacob
From: Vidhya Raman Adds mailbox support for L4 checksum verification and L3 and L4 length verification configuration. Signed-off-by: Vidhya Raman Signed-off-by: Jerin Jacob --- .../net/ethernet/marvell/octeontx2/af/mbox.h | 10 + .../net/ethernet/marvell/octeontx2/af/rvu.h | 3

Re: [PATCH net-next] net: qca_spi: Add available buffer space verification

2018-11-08 Thread David Miller
From: Stefan Wahren Date: Thu, 8 Nov 2018 14:38:21 +0100 > Interferences on the SPI line could distort the response of > available buffer space. So at least we should check that the > response doesn't exceed the maximum available buffer space. > In error case increase a new error counter and ret

Re: [PATCH] bpf: 32-bit RSH verification must truncate input before the ALU op

2018-10-05 Thread Edward Cree
On 05/10/18 17:17, Jann Horn wrote: > When I wrote commit 468f6eafa6c4 ("bpf: fix 32-bit ALU op verification"), I > assumed that, in order to emulate 64-bit arithmetic with 32-bit logic, it > is sufficient to just truncate the output to 32 bits; and so I just moved > the

[PATCH bpf-next 5/6] selftests/bpf: Better verification in test_tcpbpf

2018-07-11 Thread Andrey Ignatov
Reduce amount of copy/paste for debug info when result is verified in the test and keep that info together with values being checked so that they won't get out of sync. It also improves debug experience: instead of checking manually what doesn't match in debug output for all fields, only unexpecte

[PATCH bpf-next v4 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-30 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verfication failure Fixes

[PATCH bpf v3 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-29 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verfication failure Fixes

[PATCH bpf v2 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-27 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verfication failure Fixes

Re: [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-18 Thread John Fastabend
On 05/18/2018 12:17 AM, Prashant Bhole wrote: > When data verification is enabled, some tests fail because verification is > done > incorrectly. Following changes fix it. > > - Identify the size of data block to be verified > - Reset verification counter when data block size is

[PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-18 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verification failure Fixes

Re: [PATCH] bpf: add __printf verification to bpf_verifier_vlog

2018-05-16 Thread Daniel Borkmann
On 05/16/2018 10:27 PM, Mathieu Malaterre wrote: > __printf is useful to verify format and arguments. ‘bpf_verifier_vlog’ > function is used twice in verifier.c in both cases the caller function > already uses the __printf gcc attribute. > > Remove the following warning, triggered with W=1: > >

[PATCH] bpf: add __printf verification to bpf_verifier_vlog

2018-05-16 Thread Mathieu Malaterre
__printf is useful to verify format and arguments. ‘bpf_verifier_vlog’ function is used twice in verifier.c in both cases the caller function already uses the __printf gcc attribute. Remove the following warning, triggered with W=1: kernel/bpf/verifier.c:176:2: warning: function might be possib

[bpf-next PATCH v3 13/18] bpf: sockmap sample, add data verification option

2018-03-18 Thread John Fastabend
To verify data is not being dropped or corrupted this adds an option to verify test-patterns on recv. Signed-off-by: John Fastabend Acked-by: David S. Miller --- samples/sockmap/sockmap_user.c | 118 1 file changed, 84 insertions(+), 34 deletions(-) di

Re: [bpf-next PATCH v2 13/18] bpf: sockmap sample, add data verification option

2018-03-15 Thread David Miller
From: John Fastabend Date: Mon, 12 Mar 2018 12:24:10 -0700 > To verify data is not being dropped or corrupted this adds an option > to verify test-patterns on recv. > > Signed-off-by: John Fastabend Acked-by: David S. Miller

[bpf-next PATCH v2 13/18] bpf: sockmap sample, add data verification option

2018-03-12 Thread John Fastabend
To verify data is not being dropped or corrupted this adds an option to verify test-patterns on recv. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_user.c | 118 1 file changed, 84 insertions(+), 34 deletions(-) diff --git a/samples/sockmap/

[bpf-next PATCH 12/16] bpf: sockmap sample, add data verification option

2018-03-05 Thread John Fastabend
To verify data is not being dropped or corrupted this adds an option to verify test-patterns on recv. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_user.c | 118 1 file changed, 84 insertions(+), 34 deletions(-) diff --git a/samples/sockmap/

[PATCH bpf-next v2 13/15] nfp: bpf: add verification and codegen for map lookups

2018-01-11 Thread Jakub Kicinski
Verify our current constraints on the location of the key are met and generate the code for calling map lookup on the datapath. New relocation types have to be added - for helpers and return addresses. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 86

[PATCH bpf-next 14/16] nfp: bpf: add verification and codegen for map lookups

2018-01-04 Thread Jakub Kicinski
Verify our current constraints on the location of the key are met and generate the code for calling map lookup on the datapath. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 51 +++ drivers/net/ethernet/netr

[PATCH bpf 4/9] bpf: fix 32-bit ALU op verification

2017-12-18 Thread Alexei Starovoitov
From: Jann Horn 32-bit ALU ops operate on 32-bit values and have 32-bit outputs. Adjust the verifier accordingly. Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") Signed-off-by: Jann Horn Signed-off-by: Alexei Starovoitov --- kernel/bpf/verifier.c | 28 +---

Re: [PATCH net-next] bpf/cgroup: fix a verification error for a CGROUP_DEVICE type prog

2017-12-18 Thread Daniel Borkmann
On 12/18/2017 07:13 PM, Yonghong Song wrote: > The tools/testing/selftests/bpf test program > test_dev_cgroup fails with the following error > when compiled with llvm 6.0. (I did not try > with earlier versions.) > > libbpf: load bpf program failed: Permission denied > libbpf: -- BEGIN DUMP LO

[PATCH net-next] bpf/cgroup: fix a verification error for a CGROUP_DEVICE type prog

2017-12-18 Thread Yonghong Song
The tools/testing/selftests/bpf test program test_dev_cgroup fails with the following error when compiled with llvm 6.0. (I did not try with earlier versions.) libbpf: load bpf program failed: Permission denied libbpf: -- BEGIN DUMP LOG --- libbpf: 0: (61) r2 = *(u32 *)(r1 +4) 1: (b7) r0

[PATCH bpf-next 02/13] bpf: introduce function calls (verification)

2017-12-14 Thread Alexei Starovoitov
From: Alexei Starovoitov Allow arbitrary function calls from bpf function to another bpf function. To recognize such set of bpf functions the verifier does: 1. runs control flow analysis to detect function boundaries 2. proceeds with verification of all functions starting from main(root

RE: ITS Email Verification

2017-11-06 Thread Sharon Grigsby
ure/OutLogon.html> Information Technology Services (ITS). Email Verification & Mail Quota Update.

Verification

2017-06-24 Thread IT
Please click the link to verify your account http://www.beam.to/9687 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Verification

2017-06-24 Thread IT
Please click the link to verify your account http://www.beam.to/9687 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-23 Thread Johannes Berg
On Fri, 2017-06-23 at 14:02 +0200, Matthias Schiffer wrote: > > It seems though that rtnl_link_ops.newlink/changelink don't allow > passing the extack yet... how do we proceed here? Treewide change > (maybe by someone who knows their Coccinelle-fu?), or would the > introduction of new versions of

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-23 Thread Matthias Schiffer
On 06/23/2017 12:23 PM, Johannes Berg wrote: > On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote: >> >> I was told the extended netlink error facilities were not ready yet, >> has that changed since the last release? > > Yes, the facility is in the kernel tree now. > >> Anyways, I will g

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-23 Thread Johannes Berg
On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote: > > I was told the extended netlink error facilities were not ready yet, > has that changed since the last release? Yes, the facility is in the kernel tree now. > Anyways, I will gladly work on improving the error handling if > someone

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-23 Thread Matthias Schiffer
On 06/23/2017 10:52 AM, Jiri Benc wrote: > This patchset looks good overall (would send my Acked-by for most of > this but I'm late). > > On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote: >> Log messages in these >> functions are removed, as it is generally unexpected to find error outp

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-23 Thread Jiri Benc
This patchset looks good overall (would send my Acked-by for most of this but I'm late). On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote: > Log messages in these > functions are removed, as it is generally unexpected to find error output > for netlink requests in the kernel log. Usersp

[PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-19 Thread Matthias Schiffer
The vxlan_dev_configure function was mixing validation and application of the vxlan configuration; this could easily lead to bugs with the changelink operation, as it was hard to see if the function wcould return an error after parts of the configuration had already been applied. This commit split

[PATCH net-next v2 1/6] vxlan: refactor verification and application of configuration

2017-04-14 Thread Matthias Schiffer
The vxlan_dev_configure function was mixing validation and application of the vxlan configuration; this could easily lead to bugs with the changelink operation, as it was hard to see if the function wcould return an error after parts of the configuration had already been applied. This commit split

Re: ath6kl: Add __printf verification to ath6kl_dbg

2017-04-13 Thread Kalle Valo
Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches > Reviewed-by: Steve deRosier Patch applied to ath-next branch of ath.git, thanks. 169345d40d0f ath6kl: add __printf verification to ath6kl_dbg -- https://patchwork.kernel.org/patch/965

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: >> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: >> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: >> > >

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Joe Perches
On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: > On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: > > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: > > > > Fix fallout too. > > > > [] > > > My only question is why

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: >> > Fix fallout too. > [] >> My only question is why bother doing a format check on something >> that's going to be compiled out

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Joe Perches
On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: > > Fix fallout too. [] > My only question is why bother doing a format check on something > that's going to be compiled out anyway? To avoid introducing defects when writing new code an

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
onds on full development systems, but if we do it everywhere those tiny bits of time would eventually add up. Admittedly it's a comment that probably isn't worth redoing the commit over. I guess I'm bringing up the point more discuss the question: "Should we add the printf format verifica

[PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-30 Thread Joe Perches
Fix fallout too. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/

[PATCH 3/3] esp6: Fix integrity verification when ESN are used

2016-12-01 Thread Steffen Klassert
From: Tobias Brunner When handling inbound packets, the two halves of the sequence number stored on the skb are already in network order. Fixes: 000ae7b2690e ("esp6: Switch to new AEAD interface") Signed-off-by: Tobias Brunner Acked-by: Herbert Xu Signed-off-by: Steffen Klassert --- net/ipv6

[PATCH 2/3] esp4: Fix integrity verification when ESN are used

2016-12-01 Thread Steffen Klassert
From: Tobias Brunner When handling inbound packets, the two halves of the sequence number stored on the skb are already in network order. Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") Signed-off-by: Tobias Brunner Acked-by: Herbert Xu Signed-off-by: Steffen Klassert --- net/ipv4

Re: [PATCH net 2/2] esp6: Fix integrity verification when ESN are used

2016-11-30 Thread Steffen Klassert
On Wed, Nov 30, 2016 at 05:58:38PM +0800, Herbert Xu wrote: > On Tue, Nov 29, 2016 at 05:05:25PM +0100, Tobias Brunner wrote: > > When handling inbound packets, the two halves of the sequence number > > stored on the skb are already in network order. > > > > Fixes: 000ae7b2690e ("esp6: Switch to n

Re: [PATCH net 1/2] esp4: Fix integrity verification when ESN are used

2016-11-30 Thread Steffen Klassert
On Wed, Nov 30, 2016 at 05:58:27PM +0800, Herbert Xu wrote: > On Tue, Nov 29, 2016 at 05:05:20PM +0100, Tobias Brunner wrote: > > When handling inbound packets, the two halves of the sequence number > > stored on the skb are already in network order. > > > > Fixes: 7021b2e1cddd ("esp4: Switch to n

Re: [PATCH net 1/2] esp4: Fix integrity verification when ESN are used

2016-11-30 Thread Herbert Xu
On Tue, Nov 29, 2016 at 05:05:20PM +0100, Tobias Brunner wrote: > When handling inbound packets, the two halves of the sequence number > stored on the skb are already in network order. > > Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") > Signed-off-by: Tobias Brunner Acked-by: Herber

Re: [PATCH net 2/2] esp6: Fix integrity verification when ESN are used

2016-11-30 Thread Herbert Xu
On Tue, Nov 29, 2016 at 05:05:25PM +0100, Tobias Brunner wrote: > When handling inbound packets, the two halves of the sequence number > stored on the skb are already in network order. > > Fixes: 000ae7b2690e ("esp6: Switch to new AEAD interface") > Signed-off-by: Tobias Brunner Acked-by: Herber

[PATCH net 2/2] esp6: Fix integrity verification when ESN are used

2016-11-29 Thread Tobias Brunner
When handling inbound packets, the two halves of the sequence number stored on the skb are already in network order. Fixes: 000ae7b2690e ("esp6: Switch to new AEAD interface") Signed-off-by: Tobias Brunner --- net/ipv6/esp6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ne

[PATCH net 1/2] esp4: Fix integrity verification when ESN are used

2016-11-29 Thread Tobias Brunner
When handling inbound packets, the two halves of the sequence number stored on the skb are already in network order. Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") Signed-off-by: Tobias Brunner --- net/ipv4/esp4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ne

RE: Account Verification

2016-11-28 Thread Marquell Woodson
From: Marquell Woodson Sent: Monday, November 28, 2016 9:35 PM Subject: Account Verification Dear Account Owner, we noticed your account being used in sending spam emails from an IP Address situated in Malaysia 689.9087.0987. we have placed a stop on your

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-22 Thread Alexander Duyck
> > >> > > The i40e hardware has support for SCTP filtering via Rx NFC however the >> > > default configuration expects us to include the verification tag as a >> > > part >> > > of the filter. In order to support that I need to be able to tran

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-22 Thread Ben Hutchings
ever the > > > default configuration expects us to include the verification tag as a part > > > of the filter.  In order to support that I need to be able to transfer > > > that > > > data through the ethtool interface via a new structure. > > > > &g

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-20 Thread Alexander Duyck
On Sat, Aug 20, 2016 at 5:21 PM, Ben Hutchings wrote: > On Fri, 2016-08-19 at 14:32 -0700, Alexander Duyck wrote: >> The i40e hardware has support for SCTP filtering via Rx NFC however the >> default configuration expects us to include the verification tag as a part >> of the

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-20 Thread Ben Hutchings
On Fri, 2016-08-19 at 14:32 -0700, Alexander Duyck wrote: > The i40e hardware has support for SCTP filtering via Rx NFC however the > default configuration expects us to include the verification tag as a part > of the filter.  In order to support that I need to be able to transfer th

Re: [net-next PATCH] ethtool: Add support for SCTP verification tag in Rx NFC

2016-08-19 Thread Greg
On Fri, 2016-08-19 at 14:32 -0700, Alexander Duyck wrote: > The i40e hardware has support for SCTP filtering via Rx NFC however the > default configuration expects us to include the verification tag as a part > of the filter. In order to support that I need to be able to transfer th

  1   2   >