Re: WARNING: refcount bug in should_fail

Eric W. Biederman wrote: > Al Viro writes: > > > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > > > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort > >> of bugs (most of them preexisting, but I should've checked instead > >> of assuming

Re: WARNING: refcount bug in should_fail

Al Viro writes: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that everything's fine). Will push

Re: WARNING: refcount bug in should_fail

On Tue, Apr 3, 2018 at 7:20 AM, Al Viro wrote: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that

Re: WARNING: refcount bug in should_fail

On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > FWIW, I'm going through the ->kill_sb() instances, fixing that sort > of bugs (most of them preexisting, but I should've checked instead > of assuming that everything's fine). Will push out later tonight. OK, see vfs.git#for-linus.

Re: WARNING: refcount bug in should_fail

On Mon, Apr 02, 2018 at 10:52:12PM +0100, Al Viro wrote: > On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > > Tetsuo Handa writes: > > > > I don't think this is a dup of existing bug. > > > We need to fix either 9ee332d99e4d5a97 or

Re: WARNING: refcount bug in should_fail

On Mon, Apr 02, 2018 at 03:30:56PM -0500, Eric W. Biederman wrote: > Tetsuo Handa writes: > > I don't think this is a dup of existing bug. > > We need to fix either 9ee332d99e4d5a97 or d91ee87d8d85a080. > > Even if expanding mount_ns to more filesystems was

Re: WARNING: refcount bug in should_fail

>> >> from >> >> deactivate_locked_super()). >> >> >> -- >> >> static struct dentry * >> >> rpc_mount(struct file_system_type *fs_type, >> >> int flags, const char *dev_name, void *data) >&g

Re: WARNING: refcount bug in should_fail

t; not called by rpc_fill_super() (via fill_super callback passed to >>>> >> mount_ns()) >>>> >> but put_net(sb->s_fs_info) is called by rpc_kill_sb() (via >>>> >> fs->kill_sb() from >>>> >> deactivate_locked_super()). >>>> >

Re: WARNING: refcount bug in should_fail

;kill_sb() >>> >> from >>> >> deactivate_locked_super()). >>> >> >>> >> -- >>> >> static struct dentry * >>> >> rpc_mount(struct file_system_type *fs_type, >>> >>

Re: WARNING: refcount bug in should_fail

t; >> rpc_mount(struct file_system_type *fs_type, >> >> int flags, const char *dev_name, void *data) >> >> { >> >> struct net *net = current->nsproxy->net_ns; >> >> return mount_ns(fs_type, flags, data, ne

Re: WARNING: refcount bug in should_fail

_locked_super()). > >> > >> -- > >> static struct dentry * > >> rpc_mount(struct file_system_type *fs_type, > >> int flags, const char *dev_name, void *data) > >> { > >> struct net *net = current->nsp

Re: WARNING: refcount bug in should_fail

rpc_mount(struct file_system_type *fs_type, > >> int flags, const char *dev_name, void *data) > >> { > >> struct net *net = current->nsproxy->net_ns; > >> return mount_ns(fs_type, flags, data, net, net->user_ns,

Re: WARNING: refcount bug in should_fail

*dev_name, void *data) >> { >> struct net *net = current->nsproxy->net_ns; >> return mount_ns(fs_type, flags, data, net, net->user_ns, >> rpc_fill_super); >> } >> -- > > Messed kernel output, this is definitely not in shoul

Re: Re: WARNING: refcount bug in should_fail

e_system_type *fs_type, int flags, const char *dev_name, void *data) { struct net *net = current->nsproxy->net_ns; return mount_ns(fs_type, flags, data, net, net->user_ns, rpc_fill_super); } -- Messed kernel output, this is definitely n

Re: WARNING: refcount bug in should_fail

gt; > -- > static struct dentry * > rpc_mount(struct file_system_type *fs_type, > int flags, const char *dev_name, void *data) > { > struct net *net = current->nsproxy->net_ns; > return mount_ns(fs_type, flags, data, net, net->user_ns,

Re: WARNING: refcount bug in should_fail

Switching from mm to fsdevel, for this report says that put_net(net) in rpc_kill_sb() made net->count < 0 when mount_ns() failed due to register_shrinker() failure. Relevant commits will be commit 9ee332d99e4d5a97 ("sget(): handle failures of register_shrinker()") and commit d91ee87d8d85a080