Re: bcm43xx dma and txb's

2006-03-05 Thread Pete Zaitcev
On Mon, 6 Mar 2006 01:11:28 +0100, Michael Buesch <[EMAIL PROTECTED]> wrote: > But: This shows us that the struct ieee80211_txb is useless > and should be eliminated. Look at how d80211 handles fragments. > It sends every single fragment in an skb to the driver. I think > this is _much_ more painl

Re: bcm43xx dma and txb's

2006-03-05 Thread Michael Buesch
On Monday 06 March 2006 00:43, you wrote: > > + txb->fragments[i] = NULL; /* Take skb from ieee80211_txb_free */ > > + dma_tx_fragment(ring, skb, i); > > //TODO: handle failure of dma_tx_fragment > > } > > > > + ieee80211_txb_free(txb); > > This seems even m

Re: bcm43xx dma and txb's

2006-03-05 Thread Pete Zaitcev
On Mon, 6 Mar 2006 00:43:24 +0100, Michael Buesch <[EMAIL PROTECTED]> wrote: > Yes, but I think the fix is to save the txb when transmitting > the last fragment rather than the first. This was my idea at first, too. > > + txb->fragments[i] = NULL; /* Take skb from ieee80211_txb_free */

Re: bcm43xx dma and txb's

2006-03-05 Thread Michael Buesch
On Monday 06 March 2006 00:09, you wrote: > Hi, Michael: > > It seems to me that the today's wireless-2.6 git contains bcm43xx which > does not free txb's correctly, if I understand it right. > > Consider a situation where a txb with two skb's is sent down. > The dma_tx_fragment will save the poi