Re: bpf: btf: Change how section is supported in btf_header

2018-09-12 Thread Dmitry Vyukov
On Tue, Sep 11, 2018 at 8:10 PM, Martin KaFai Lau wrote: > On Tue, Sep 11, 2018 at 06:40:05PM +0200, Dmitry Vyukov wrote: >> Hi Martin, >> >> I am looking at the subj commit: >> >> static int btf_add_type(struct btf_verifier_env *env, struct btf_type *t) >> @@ -1754,9 +1756,9 @@ static int

Re: bpf: btf: Change how section is supported in btf_header

2018-09-11 Thread Martin KaFai Lau
On Tue, Sep 11, 2018 at 06:40:05PM +0200, Dmitry Vyukov wrote: > Hi Martin, > > I am looking at the subj commit: > > static int btf_add_type(struct btf_verifier_env *env, struct btf_type *t) > @@ -1754,9 +1756,9 @@ static int btf_check_all_metas(struct > btf_verifier_env *env) > struct

Re: bpf: btf: Change how section is supported in btf_header

2018-09-11 Thread Dmitry Vyukov
Hi Martin, I am looking at the subj commit: static int btf_add_type(struct btf_verifier_env *env, struct btf_type *t) @@ -1754,9 +1756,9 @@ static int btf_check_all_metas(struct btf_verifier_env *env) struct btf_header *hdr; void *cur, *end; - hdr = btf->hdr; + hdr

[PATCH bpf-next v2 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-22 Thread Martin KaFai Lau
There are currently unused section descriptions in the btf_header. Those sections are here to support future BTF use cases. For example, the func section (func_off) is to support function signature (e.g. the BPF prog function signature). Instead of spelling out all potential sections up-front

Re: [PATCH bpf-next 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-21 Thread Martin KaFai Lau
On Mon, May 21, 2018 at 01:15:24PM -0700, Yonghong Song wrote: > > > On 5/18/18 5:16 PM, Martin KaFai Lau wrote: > > There are currently unused section descriptions in the btf_header. Those > > sections are here to support future BTF use cases. For example, the > > func section (func_off) is

Re: [PATCH bpf-next 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-21 Thread Yonghong Song
On 5/18/18 5:16 PM, Martin KaFai Lau wrote: There are currently unused section descriptions in the btf_header. Those sections are here to support future BTF use cases. For example, the func section (func_off) is to support function signature (e.g. the BPF prog function signature). Instead

[PATCH bpf-next 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-18 Thread Martin KaFai Lau
There are currently unused section descriptions in the btf_header. Those sections are here to support future BTF use cases. For example, the func section (func_off) is to support function signature (e.g. the BPF prog function signature). Instead of spelling out all potential sections up-front