Re: d80211: a patch for standalone d80211 tarball

2007-01-31 Thread Jiri Benc
On Mon, 29 Jan 2007 15:23:07 -0500, Pavel Roskin wrote: Both cases are highly unlikely for the above macros, but please keep in mind that some aspiring programmers view the kernel as an example of good programming style. This wasn't meant to be included in the kernel (that would be indeed bad,

d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Jiri Benc
This patch should be enough to allow creation of standalone d80211 tarball (i.e. version of d80211 that could be compiled without patching the vanilla kernel) after invisible master interface patches. It is completely untested. Signed-off-by: Jiri Benc [EMAIL PROTECTED] ---

Re: d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Ivo Van Doorn
Hi, This patch should be enough to allow creation of standalone d80211 tarball (i.e. version of d80211 that could be compiled without patching the vanilla kernel) after invisible master interface patches. That looks very nice indeed, that saves me quite a big patch I usually apply to the

Re: d80211: a patch for standalone d80211 tarball

2007-01-29 Thread Pavel Roskin
Hi, Jiri! On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote: +#define register_invisible_netdevice register_netdevice +#define unregister_invisible_netdevice unregister_netdevice Please use macros with arguments whenever possible. This way, incorrect macro invocations would be