Re: e100: Wait for PHY reset to complete?

2006-10-31 Thread Auke Kok
Anders Grafström wrote: Anders Grafström wrote: I ran mii-diag when the LEDs went out and the register dump said it was in loopback. It is somewhat difficult reproduce. It seems to be timing dependent, something else has to occur at the same time. I must confess I have only seen it with the 2.6.

Re: e100: Wait for PHY reset to complete?

2006-10-31 Thread Anders Grafström
>> Anders Grafström wrote: >>> I ran mii-diag when the LEDs went out and the register dump >>> said it was in loopback. It is somewhat difficult reproduce. >>> It seems to be timing dependent, something else has to occur >>> at the same time. >>> I must confess I have only seen it with the 2.6.13 k

Re: e100: Wait for PHY reset to complete?

2006-10-30 Thread Auke Kok
Auke Kok wrote: Anders Grafström wrote: Auke Kok wrote: Allthough the spec itself didn't talk about phy reset times, I've ran this patch with some debugging output on a few boxes and did some speed/duplex settings, and the PHY reset returned succesfull after the very first mdio_read, which is

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Auke Kok
Anders Grafström wrote: Auke Kok wrote: Allthough the spec itself didn't talk about phy reset times, I've ran this patch with some debugging output on a few boxes and did some speed/duplex settings, and the PHY reset returned succesfull after the very first mdio_read, which is before any msleep(

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Anders Grafström
Auke Kok wrote: > Allthough the spec itself didn't talk about phy reset times, I've ran this > patch with > some debugging output on a few boxes and did some speed/duplex settings, > and the PHY > reset returned succesfull after the very first mdio_read, which is before > any msleep(10) > is execut

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Francois Romieu
Auke Kok <[EMAIL PROTECTED]> : [...] > okay, I don't think this is needed at all: > > Allthough the spec itself didn't talk about phy reset times, I've ran this > patch with some debugging output on a few boxes and did some speed/duplex > settings, and the PHY reset returned succesfull after the

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Auke Kok
Auke Kok wrote: Francois Romieu wrote: Anders Grafstrom <[EMAIL PROTECTED]> : [...] I'm thinking something like this patch. I do not have the spec for the max duration at hand but it makes sense. Can you: - decrease the duration of each sleep and increase the count of iterations - put the

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Auke Kok
Francois Romieu wrote: Anders Grafstrom <[EMAIL PROTECTED]> : [...] I'm thinking something like this patch. I do not have the spec for the max duration at hand but it makes sense. Can you: - decrease the duration of each sleep and increase the count of iterations - put the break on a line of

Re: e100: Wait for PHY reset to complete?

2006-10-25 Thread Francois Romieu
Anders Grafstrom <[EMAIL PROTECTED]> : [...] > I'm thinking something like this patch. I do not have the spec for the max duration at hand but it makes sense. Can you: - decrease the duration of each sleep and increase the count of iterations - put the break on a line of its own - add a Signed-of

e100: Wait for PHY reset to complete?

2006-10-25 Thread Anders Grafstrom
Shouldn't the e100 driver wait for PHY reset to complete before proceeding in e100_set_settings()? I'm asking because the interface (82551) sometimes ends up in loopback when I try to set AUTONEG. I'm thinking something like this patch. Anders --- linux-2.6.18.orig/drivers/net/e100.c20