Re: ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-19 Thread Randy Dunlap
On 8/19/20 3:37 AM, Edward Cree wrote: > On 19/08/2020 01:28, Randy Dunlap wrote: >> Hi, >> >> Does the drivers/net/ethernet/sfc/sfc driver require (expect) >> dma_addr_t to be 64 bits (as opposed to 32 bits)? >> >> I see that several #defines in ef100_regs.h are 64... >> >> When used with DMA_BIT_

Re: ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 11:37:00AM +0100, Edward Cree wrote: > As far as I can tell, truncation to 32 bits is harmless ??? the > ??called function (efx_init_io) already tries every mask from the > ??passed one down to 32 bits in case of PCIe hardware limitations. Which btw isn't needed. These day

Re: ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-19 Thread Edward Cree
On 19/08/2020 01:28, Randy Dunlap wrote: > Hi, > > Does the drivers/net/ethernet/sfc/sfc driver require (expect) > dma_addr_t to be 64 bits (as opposed to 32 bits)? > > I see that several #defines in ef100_regs.h are 64... > > When used with DMA_BIT_MASK(64), does the value just need to be > trunca

ethernet/sfc/ warnings with 32-bit dma_addr_t

2020-08-18 Thread Randy Dunlap
Hi, Does the drivers/net/ethernet/sfc/sfc driver require (expect) dma_addr_t to be 64 bits (as opposed to 32 bits)? I see that several #defines in ef100_regs.h are 64... When used with DMA_BIT_MASK(64), does the value just need to be truncated to 32 bits? Will that work? When I build this dri