Re: i40e_pto.c: Odd use of strlcpy converted from strncpy

2019-10-07 Thread Jeff Kirsher
On Mon, 2019-10-07 at 13:48 -0700, Joe Perches wrote: > On Mon, 2019-10-07 at 13:44 -0700, Jeff Kirsher wrote: > > On Sun, 2019-10-06 at 10:19 -0700, Joe Perches wrote: > > > This got converted from strncpy to strlcpy but it's > > > now not necessary to use one character less than the > > > actual

Re: i40e_pto.c: Odd use of strlcpy converted from strncpy

2019-10-07 Thread Joe Perches
On Mon, 2019-10-07 at 13:44 -0700, Jeff Kirsher wrote: > On Sun, 2019-10-06 at 10:19 -0700, Joe Perches wrote: > > This got converted from strncpy to strlcpy but it's > > now not necessary to use one character less than the > > actual size. > > > > Perhaps the sizeof() - 1 is now not correct and i

Re: i40e_pto.c: Odd use of strlcpy converted from strncpy

2019-10-07 Thread Jeff Kirsher
On Sun, 2019-10-06 at 10:19 -0700, Joe Perches wrote: > This got converted from strncpy to strlcpy but it's > now not necessary to use one character less than the > actual size. > > Perhaps the sizeof() - 1 is now not correct and it > should use strscpy and a normal sizeof. > > from: > > commit

i40e_pto.c: Odd use of strlcpy converted from strncpy

2019-10-06 Thread Joe Perches
This got converted from strncpy to strlcpy but it's now not necessary to use one character less than the actual size. Perhaps the sizeof() - 1 is now not correct and it should use strscpy and a normal sizeof. from: commit 7eb74ff891b4e94b8bac48f648a21e4b94ddee64 Author: Mitch Williams Date: M