Re: iscsi target regression due to "tcp: remove prequeue support" patch

On 01/18/2018 09:10 AM, Florian Westphal wrote: >> It would indicate users providing their own ->sk_data_ready() callback >> must be responsible for waking up a kthread context blocked on >> sock_recvmsg(..., MSG_WAITALL), when a second ->sk_data_ready() is >> received before the first

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Nicholas A. Bellinger wrote: > On Mon, 2018-01-15 at 11:41 +0100, Florian Westphal wrote: > > Mike Christie wrote: > > > > > Dec 13 17:55:01 rhel73n1 kernel: Got Login Command, Flags 0x81, ITT: > > > 0x, CmdSN: 0x, ExpStatSN:

Re: iscsi target regression due to "tcp: remove prequeue support" patch

On Mon, 2018-01-15 at 14:33 -0600, Mike Christie wrote: > On 01/15/2018 12:41 AM, Nicholas A. Bellinger wrote: > > Hey MNC & Co, > > > > Ping on the earlier iscsi-target authentication login failures atop > > 4.14 + commit e7942d063 removing tcp prequeue support. > > > > For reference, what is

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hi Florian, (Adding netdev + DaveM CC') Thanks for the response. Comments below. On Mon, 2018-01-15 at 11:41 +0100, Florian Westphal wrote: > Mike Christie wrote: > > > Dec 13 17:55:01 rhel73n1 kernel: Got Login Command, Flags 0x81, ITT: > > 0x, CmdSN:

Re: iscsi target regression due to "tcp: remove prequeue support" patch

On 01/15/2018 12:41 AM, Nicholas A. Bellinger wrote: > Hey MNC & Co, > > Ping on the earlier iscsi-target authentication login failures atop > 4.14 + commit e7942d063 removing tcp prequeue support. > > For reference, what is your pre 4.14 environment using for > sysctl_tcp_low_latency..?

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hey MNC & Co, Ping on the earlier iscsi-target authentication login failures atop 4.14 + commit e7942d063 removing tcp prequeue support. For reference, what is your pre 4.14 environment using for sysctl_tcp_low_latency..? netdev folks, how would you like to proceed for -rc1..? On Mon,

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hi MNC & Florian, (Adding net-dev + DaveM CC') Catching up on pre-holiday threads, thanks for the heads up. Comments below. On Wed, 2017-12-13 at 23:56 -0600, Mike Christie wrote: > Hey Nick and Florian, > > Starting in 4.14 iscsi logins will fail around 50% of the time. > > I git bisected