Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-19 Thread Xin Long
On Sat, Jan 20, 2018 at 1:19 AM, Guillaume Nault wrote: > On Tue, Jan 16, 2018 at 04:21:40PM +0800, Xin Long wrote: >> ipv4 tunnels don't really set dev->hard_header_len properly, >> we may should fix it in pppoe by using needed_headroom, >> as what it doesn't in arp_create. >> > I'm a bit in dou

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-19 Thread Guillaume Nault
On Tue, Jan 16, 2018 at 04:21:40PM +0800, Xin Long wrote: > ipv4 tunnels don't really set dev->hard_header_len properly, > we may should fix it in pppoe by using needed_headroom, > as what it doesn't in arp_create. > I'm a bit in doubt about which device needs to be fixed. Should ip_gre set ->har

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-16 Thread Xin Long
On Tue, Jan 16, 2018 at 4:22 AM, syzbot wrote: > syzkaller has found reproducer for the following crash on > b625c1ff82272e26c76570d3c7123419ec345b20 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Eric Dumazet
On Sun, 2017-12-10 at 12:38 +0800, Xin Long wrote: > On Sun, Dec 10, 2017 at 3:36 AM, Cong Wang > wrote: > > On Fri, Dec 8, 2017 at 12:45 AM, Xin Long > > wrote: > > > This isn't a sctp problem, but mld's, seems when lo's mtu became > > > 0, > > > it allocs a skb without enough space in add_grec(

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Eric Dumazet
On Sun, 2017-12-10 at 12:36 +0800, Xin Long wrote: > The new patch works to me, just two questions: > 1. should it use "idev->cnf.mtu6" here for mld ? No idea why some parts of IPv6 would use a different view of device mtu. Maybe others can comment. > > 2.  'if (int < unsigned int)' is still not

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Xin Long
On Sun, Dec 10, 2017 at 3:36 AM, Cong Wang wrote: > On Fri, Dec 8, 2017 at 12:45 AM, Xin Long wrote: >> This isn't a sctp problem, but mld's, seems when lo's mtu became 0, >> it allocs a skb without enough space in add_grec(): > > Shouldn't we just set its min_mtu to ETH_MIN_MTU? No idea why ther

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Xin Long
On Sun, Dec 10, 2017 at 12:59 AM, Eric Dumazet wrote: > On Sat, 2017-12-09 at 19:23 +0800, Xin Long wrote: >> On Fri, Dec 8, 2017 at 4:45 PM, Xin Long >> wrote: >> > On Fri, Dec 8, 2017 at 4:16 PM, syzbot >> > > > .com> >> > wrote: >> > > syzkaller has found reproducer for the following crash on

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Cong Wang
On Fri, Dec 8, 2017 at 12:45 AM, Xin Long wrote: > This isn't a sctp problem, but mld's, seems when lo's mtu became 0, > it allocs a skb without enough space in add_grec(): Shouldn't we just set its min_mtu to ETH_MIN_MTU?

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Eric Dumazet
On Sat, 2017-12-09 at 19:23 +0800, Xin Long wrote: > On Fri, Dec 8, 2017 at 4:45 PM, Xin Long > wrote: > > On Fri, Dec 8, 2017 at 4:16 PM, syzbot > > > .com> > > wrote: > > > syzkaller has found reproducer for the following crash on > > > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > > > git://git.c

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-09 Thread Xin Long
On Fri, Dec 8, 2017 at 4:45 PM, Xin Long wrote: > On Fri, Dec 8, 2017 at 4:16 PM, syzbot > > wrote: >> syzkaller has found reproducer for the following crash on >> 82bcf1def3b5f1251177ad47c44f7e17af039b4b >> git://git.cmpxchg.org/linux-mmots.git/master >> compiler: gcc (GCC) 7.1.1 20170620 >> .co

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-12-08 Thread Xin Long
On Fri, Dec 8, 2017 at 4:16 PM, syzbot wrote: > syzkaller has found reproducer for the following crash on > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > > syzka

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-11-05 Thread Xin Long
On Mon, Oct 30, 2017 at 10:36 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > c69fe407803d4b554b7397fad9598a04717ac255 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is