Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-15 Thread Paolo Abeni
On Tue, 2016-11-15 at 06:02 -0800, Eric Dumazet wrote: > On Tue, 2016-11-15 at 10:26 +0100, Paolo Abeni wrote: > > Hi, > > > > On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: > > > Our test system detected a kernel oops. Looks like a problem in the > > > "udp: refactor memory accounting" se

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-15 Thread Eric Dumazet
On Tue, 2016-11-15 at 10:26 +0100, Paolo Abeni wrote: > Hi, > > On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: > > Our test system detected a kernel oops. Looks like a problem in the > > "udp: refactor memory accounting" series. > > My fault: I missed udplite in my tests. > > Thank you f

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-15 Thread Paolo Abeni
Hi, On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: > Our test system detected a kernel oops. Looks like a problem in the > "udp: refactor memory accounting" series. My fault: I missed udplite in my tests. Thank you for reporting. I'm fine with Eric's patch, setting both .memory_allocate

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-15 Thread Paolo Abeni
On Mon, 2016-11-14 at 16:31 -0800, Eric Dumazet wrote: > On Mon, 2016-11-14 at 15:58 -0800, Andrei Vagin wrote: > > > > > Yes, you are right. It works if we set .memory_allocated and .sysctl_mem. > > Now the question would be : > > Are we okay if UDP and UDPlite share the same limits ? > > I w

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:58 -0800, Andrei Vagin wrote: > > Yes, you are right. It works if we set .memory_allocated and .sysctl_mem. Now the question would be : Are we okay if UDP and UDPlite share the same limits ? I would vote for yes, because these default limits are huge anyway (The 50% re

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
On Mon, Nov 14, 2016 at 3:24 PM, Andrei Vagin wrote: > Hi Paolo, > > Our test system detected a kernel oops. Looks like a problem in the > "udp: refactor memory accounting" series. > > # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement > memory accounting helpers > git bisect good f

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
On Mon, Nov 14, 2016 at 3:35 PM, Eric Dumazet wrote: > On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: >> Hi Paolo, >> >> Our test system detected a kernel oops. Looks like a problem in the >> "udp: refactor memory accounting" series. >> >> # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb]

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:35 -0800, Eric Dumazet wrote: > > Thanks for the report. > > I guess following patch would be needed ? > > diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c > index > af817158d830c0da080935ba29e012dffbb89112..12604c0371c451efcc9aad278bb86be9ac4bb813 > 100644 > ---

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: > Hi Paolo, > > Our test system detected a kernel oops. Looks like a problem in the > "udp: refactor memory accounting" series. > > # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement > memory accounting helpers > git bisect goo

linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
Hi Paolo, Our test system detected a kernel oops. Looks like a problem in the "udp: refactor memory accounting" series. # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement memory accounting helpers git bisect good f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb # bad: [2d0e30c30f84d08dc16f